Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported getCommandBarStyles #24476

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

To better support removing deep imports in ODSP.

Changes

  • added top-level export of CommandBar getStyles as getCommandBarStyles
  • added top-level export getCommandButtonStyles

Issues

Fixes #24453

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Aug 23, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team as a code owner August 23, 2022 17:23
@msft-fluent-ui-bot msft-fluent-ui-bot added Fabric 7 Component: CommandBar PR: API Modified needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Aug 23, 2022
Copy link
Collaborator

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 988305c:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 23, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-CommandBar 199 kB 199.093 kB ExceedsBaseline     93 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 0bc3300f373be2f596cab45bb319cc4afb09c082 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 765 764 5000
Breadcrumb mount 34442 34344 5000
Checkbox mount 1276 1290 5000
CheckboxBase mount 1067 1073 5000
ChoiceGroup mount 4019 4034 5000
ComboBox mount 705 718 1000
CommandBar mount 6463 6525 1000
ContextualMenu mount 11009 10807 1000
DefaultButton mount 933 929 5000
DetailsRow mount 2985 2981 5000
DetailsRowFast mount 3031 2991 5000
DetailsRowNoStyles mount 2835 2813 5000
Dialog mount 1767 1753 1000
DocumentCardTitle mount 1537 1570 1000
Dropdown mount 2028 2035 5000
FocusTrapZone mount 1422 1396 5000
FocusZone mount 1512 1505 5000
IconButton mount 1362 1378 5000
Label mount 319 312 5000
Layer mount 1627 1632 5000
Link mount 404 408 5000
MenuButton mount 1175 1176 5000
MessageBar mount 1750 1775 5000
Nav mount 2575 2609 1000
OverflowSet mount 1181 1209 5000
Panel mount 1178 1167 1000
Persona mount 796 803 1000
Pivot mount 1116 1104 1000
PrimaryButton mount 1052 1057 5000
Rating mount 6777 6676 5000
SearchBox mount 1068 1056 5000
Shimmer mount 2260 2284 5000
Slider mount 1289 1284 5000
SpinButton mount 3958 3921 5000
Spinner mount 387 388 5000
SplitButton mount 2474 2465 5000
Stack mount 463 460 5000
StackWithIntrinsicChildren mount 1381 1389 5000
StackWithTextChildren mount 4260 4283 5000
SwatchColorPicker mount 8076 8205 5000
TagPicker mount 2116 2133 5000
TeachingBubble mount 41273 41437 5000
Text mount 399 390 5000
TextField mount 1133 1151 5000
Toggle mount 736 747 5000
button mount 83 84 5000

@GeoffCoxMSFT GeoffCoxMSFT merged commit 5400892 into microsoft:7.0 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CommandBar Fluent UI react (v7) needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master PR: API Modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants