Rename @uifabric/styling to @fluentui/style-utilities #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
behowell,
bigbadcapers,
dzearing,
evlevy,
Jahnp,
joschect,
khmakoto,
lorejoh12,
phkuo,
pompomon and
xugao
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9722957:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 42dd013887414826ea5ba71ba936d52a580938b9 (build) |
ecraig12345
force-pushed
the
rename-styling
branch
from
fdc3a40
to
7c410bf
Compare
behowell
approved these changes
Oct 17, 2020
Comment on lines
-105
to
+107
| This tool helps you easily create all the shades and slots for a custom theme. The theme can be used by | ||
| Fabric React's styling package, see the{' '} | ||
| {/* eslint-disable-next-line @fluentui/max-len */} | ||
| This tool helps you easily create all the shades and slots for a custom theme. The theme can be used by the{' '} | ||
| <code>@fluentui/style-utilities</code> package; see the{' '} |
There was a problem hiding this comment.
(nit) maybe just reflow the line instead of disabling the line length warning?
There was a problem hiding this comment.
Unfortunately this is one of the handful of cases where prettier and eslint conflict--prettier thinks the line is "prettiest"(??) this way despite being slightly over the max length, but eslint doesn't have that exception. There's not an easy way to change how prettier formats things, so usually in cases like this we disable the lint rule one-off.
xugao
reviewed
Oct 17, 2020
xugao
approved these changes
Oct 17, 2020
ecraig12345
force-pushed
the
rename-styling
branch
from
2005b1e
to
0f5bc49
Compare
ecraig12345
force-pushed
the
rename-styling
branch
from
0f5bc49
to
d0d4cb0
Compare
ecraig12345
force-pushed
the
rename-styling
branch
from
45126a2
to
39ab18c
Compare
2 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Rename
@uifabric/stylingto@fluentui/style-utilities.