Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @uifabric/experiments to @fluentui/react-experiments #15566

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Rename @uifabric/experiments to @fluentui/react-experiments #15566

merged 3 commits into from
Oct 17, 2020

Conversation

ecraig12345
Copy link
Member

Pull request checklist

Description of changes

Rename @uifabric/charting to @fluentui/react-charting. We're adding the react- prefix to follow the convention of other packages, now that there are packages using multiple web frameworks within the repo.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fed858:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 16, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 793 794 5000
BaseButtonCompat mount 865 876 5000
Breadcrumb mount 154053 153227 5000
Checkbox mount 1497 1484 5000
CheckboxBase mount 1246 1228 5000
ChoiceGroup mount 4600 4646 5000
ComboBox mount 890 917 1000
CommandBar mount 21030 21010 1000
ContextualMenu mount 5821 5828 1000
DefaultButtonCompat mount 1098 1074 5000
DetailsRow mount 3505 3518 5000
DetailsRowFast mount 3471 3573 5000
DetailsRowNoStyles mount 3343 3376 5000
Dialog mount 1396 1403 1000
DocumentCardTitle mount 1761 1725 1000
Dropdown mount 3559 3582 5000
FocusTrapZone mount 1730 1714 5000
FocusZone mount 1705 1737 5000
IconButtonCompat mount 1653 1685 5000
Label mount 318 316 5000
Layer mount 1723 1721 5000
Link mount 441 437 5000
MenuButtonCompat mount 1411 1435 5000
MessageBar mount 1922 1952 5000
Nav mount 3147 3124 1000
OverflowSet mount 1011 983 5000
Panel mount 1397 1415 1000
Persona mount 840 833 1000
Pivot mount 1350 1348 1000
PrimaryButtonCompat mount 1241 1249 5000
Rating mount 7170 7101 5000
SearchBox mount 1229 1252 5000
Shimmer mount 2468 2437 5000
Slider mount 1818 1817 5000
SpinButton mount 4928 4951 5000
Spinner mount 408 403 5000
SplitButtonCompat mount 3028 3053 5000
Stack mount 499 492 5000
StackWithIntrinsicChildren mount 1781 1742 5000
StackWithTextChildren mount 4675 4652 5000
SwatchColorPicker mount 9856 9787 5000
TagPicker mount 2604 2619 5000
TeachingBubble mount 11245 11116 5000
Text mount 405 403 5000
TextField mount 1345 1314 5000
ThemeProvider mount 1917 1901 5000
ThemeProvider virtual-rerender 638 633 5000
Toggle mount 749 773 5000
button mount 513 540 5000
buttonNative mount 110 111 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.49 0.88:1 2000 865
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 549
🔧 Checkbox.Fluent 0.62 0.33 1.88:1 1000 624
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 777
🔧 Dropdown.Fluent 2.83 0.41 6.9:1 1000 2832
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 695
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 390
🔧 Slider.Fluent 1.49 0.42 3.55:1 1000 1491
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 356
🦄 Tooltip.Fluent 0.11 0.86 0.13:1 5000 565

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 376 345 1.09:1
FormMinimalPerf.default 430 399 1.08:1
LabelMinimalPerf.default 431 400 1.08:1
IconMinimalPerf.default 679 629 1.08:1
ButtonMinimalPerf.default 178 168 1.06:1
DividerMinimalPerf.default 387 365 1.06:1
GridMinimalPerf.default 357 338 1.06:1
TreeWith60ListItems.default 210 199 1.06:1
DropdownManyItemsPerf.default 739 707 1.05:1
FlexMinimalPerf.default 316 300 1.05:1
AnimationMinimalPerf.default 424 408 1.04:1
CarouselMinimalPerf.default 464 446 1.04:1
ListMinimalPerf.default 490 470 1.04:1
LoaderMinimalPerf.default 741 710 1.04:1
TableMinimalPerf.default 427 410 1.04:1
TextAreaMinimalPerf.default 478 460 1.04:1
AlertMinimalPerf.default 308 298 1.03:1
ButtonUseCssNestingPerf.default 1073 1045 1.03:1
EmbedMinimalPerf.default 1894 1843 1.03:1
Tooltip.Fluent 565 551 1.03:1
ButtonSlotsPerf.default 587 573 1.02:1
ButtonUseCssPerf.default 807 789 1.02:1
ChatMinimalPerf.default 621 606 1.02:1
DialogMinimalPerf.default 779 760 1.02:1
HeaderMinimalPerf.default 368 361 1.02:1
ImageMinimalPerf.default 389 381 1.02:1
InputMinimalPerf.default 1293 1264 1.02:1
MenuButtonMinimalPerf.default 1556 1520 1.02:1
PortalMinimalPerf.default 164 161 1.02:1
ReactionMinimalPerf.default 403 395 1.02:1
Avatar.Fluent 865 846 1.02:1
Checkbox.Fluent 624 612 1.02:1
Image.Fluent 390 382 1.02:1
AttachmentSlotsPerf.default 1122 1109 1.01:1
CardMinimalPerf.default 558 553 1.01:1
CheckboxMinimalPerf.default 2778 2763 1.01:1
DropdownMinimalPerf.default 2881 2846 1.01:1
ListWith60ListItems.default 908 900 1.01:1
PopupMinimalPerf.default 682 674 1.01:1
SplitButtonMinimalPerf.default 3629 3587 1.01:1
StatusMinimalPerf.default 716 711 1.01:1
CustomToolbarPrototype.default 3765 3741 1.01:1
TooltipMinimalPerf.default 790 784 1.01:1
Dialog.Fluent 777 766 1.01:1
Text.Fluent 356 352 1.01:1
AvatarMinimalPerf.default 461 461 1:1
ButtonOverridesMissPerf.default 1644 1649 1:1
ListCommonPerf.default 625 628 1:1
MenuMinimalPerf.default 849 850 1:1
ProviderMergeThemesPerf.default 2005 2000 1:1
ProviderMinimalPerf.default 984 981 1:1
Dropdown.Fluent 2832 2841 1:1
Icon.Fluent 695 692 1:1
AccordionMinimalPerf.default 155 157 0.99:1
BoxMinimalPerf.default 353 357 0.99:1
SegmentMinimalPerf.default 349 352 0.99:1
SkeletonMinimalPerf.default 422 427 0.99:1
SliderMinimalPerf.default 1478 1499 0.99:1
TableManyItemsPerf.default 2134 2162 0.99:1
ToolbarMinimalPerf.default 909 917 0.99:1
ItemLayoutMinimalPerf.default 1224 1254 0.98:1
LayoutMinimalPerf.default 395 405 0.98:1
RadioGroupMinimalPerf.default 442 450 0.98:1
TreeMinimalPerf.default 856 873 0.98:1
AttachmentMinimalPerf.default 156 161 0.97:1
ChatWithPopoverPerf.default 449 462 0.97:1
ListNestedPerf.default 553 569 0.97:1
VideoMinimalPerf.default 624 642 0.97:1
Button.Fluent 549 566 0.97:1
Slider.Fluent 1491 1533 0.97:1
RefMinimalPerf.default 238 248 0.96:1
ChatDuplicateMessagesPerf.default 393 412 0.95:1
HeaderSlotsPerf.default 751 789 0.95:1

@size-auditor
Copy link

size-auditor bot commented Oct 16, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4123121bf1043e20e37be44b57c74456b39c4f5e (build)

@ecraig12345 ecraig12345 mentioned this pull request Oct 16, 2020
Closed
@ecraig12345 ecraig12345 merged commit 7499288 into microsoft:master Oct 17, 2020
@ecraig12345 ecraig12345 deleted the move-experiments branch October 17, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xugao xugao xugao approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp

@JasonGore JasonGore Awaiting requested review from JasonGore

@khmakoto khmakoto Awaiting requested review from khmakoto

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon ThomasMichon is a code owner

Assignees

@tomi-msft tomi-msft

Labels
Package: experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecraig12345 @msft-github-bot @xugao @tomi-msft