Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unsupported EventGrid regions #764

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Handle unsupported EventGrid regions #764

merged 8 commits into from
Jul 9, 2024

Conversation

flanakin
Copy link
Contributor

🛠️ Description

Add handling for unsupported EventGrid regions

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Yes (required for dev PRs)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Jun 24, 2024
@flanakin flanakin added this to the June 2024 milestone Jun 24, 2024
@flanakin flanakin requested a review from MSBrett as a code owner June 24, 2024 09:23
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Jun 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity label Jul 3, 2024
@flanakin flanakin requested a review from a team as a code owner July 4, 2024 21:00
@flanakin flanakin force-pushed the flanakin/dev/hubs-eventgrid-region branch from 921c4cb to b762d21 Compare July 5, 2024 01:52
@flanakin flanakin requested a review from aromano2 as a code owner July 5, 2024 01:52
@flanakin
Copy link
Contributor Author

flanakin commented Jul 6, 2024

#needs-review

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity label Jul 6, 2024
@flanakin flanakin merged commit 093a0c6 into dev Jul 9, 2024
2 checks passed
@flanakin flanakin deleted the flanakin/dev/hubs-eventgrid-region branch July 9, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSBrett MSBrett Awaiting requested review from MSBrett MSBrett is a code owner

@didayal-msft didayal-msft Awaiting requested review from didayal-msft

@aromano2 aromano2 Awaiting requested review from aromano2 aromano2 is a code owner

Assignees

@flanakin flanakin

@MSBrett MSBrett

@didayal-msft didayal-msft

Labels
Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution
Projects
None yet
Milestone
2024-07 - July
Development

Successfully merging this pull request may close these issues.
3 participants
@flanakin @didayal-msft @MSBrett