Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-commit of #2222: Expanded speaker name matching during speaker selection #2267

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

marklysze
Copy link
Collaborator

Changes committed as per #2222 to a branch within autogen repository.

Please see #2222 for the reason and code changes / revisions for "Expanded speaker name matching during speaker selection".

Related issue number

This PR replaces #2222.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.02%. Comparing base (2053dd9) to head (5a4aa5e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2267       +/-   ##
===========================================
+ Coverage   37.94%   57.02%   +19.07%     
===========================================
  Files          77       77               
  Lines        7784     7784               
  Branches     1667     1805      +138     
===========================================
+ Hits         2954     4439     +1485     
+ Misses       4580     2958     -1622     
- Partials      250      387      +137     
Flag Coverage Δ
unittest 14.36% <ø> (?)
unittests 55.87% <ø> (+17.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Apr 3, 2024
@ekzhu ekzhu removed this pull request from the merge queue due to a manual request Apr 3, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Apr 3, 2024

Thanks for the update.

@ekzhu
Copy link
Collaborator

ekzhu commented Apr 3, 2024

OpenAI tests passed except a known flaky test: https://github.com/microsoft/autogen/actions/runs/8544596821/job/23410987268?pr=2267#step:7:137
I think when the response is an error there is no cost.
cc @cheng-tan we can have a separate PR to address it.

@ekzhu ekzhu added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 89f3cfd Apr 3, 2024
73 of 75 checks passed
@ekzhu ekzhu deleted the 2222_expanded_speaker_name_handling branch April 3, 2024 23:05
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alt-models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) group chat group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants