Develop reformating prompts and readme for offline learner #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vyokky
commented
Mar 9, 2024
vyokky
commented
- Reformating prompts on examples and API calls
- remove request header defined in the main function
- Add readme and examples for offline learner.
kangyu
reviewed
Mar 11, 2024
| ACTION_SELECTION_PROMPT: "ufo/prompts/base/action_selection.yaml" # The prompt for the action selection | ||
| ACTION_SELECTION_PROMPT: "ufo/prompts/base/action_selection_rag.yaml" # The prompt for the action selection | ||
|
|
||
| APP_SELECTION_EXAMPLE_PROMPT: "ufo/prompts/examples/app_example.yaml" # The prompt for the app selection |
There was a problem hiding this comment.
May need to specify what's the difference between this prompt and previous app_selection prompt. Both called the prompt for the app selection
kangyu
reviewed
Mar 11, 2024
ufo/llm/llm_call.py
Outdated
| @@ -25,6 +47,8 @@ def get_gptv_completion(messages, headers): | |||
| return: The response of the request. | |||
| """ | |||
| aad = configs['API_TYPE'].lower() == 'azure_ad' | |||
There was a problem hiding this comment.
This is a checker variable.
Suggested change
| aad = configs['API_TYPE'].lower() == 'azure_ad' | |
| is_aad = configs['API_TYPE'].lower() == 'azure_ad' |
kangyu
reviewed
Mar 11, 2024
ufo/llm/prompt.py
Outdated
| prompts += document | ||
| prompts += "\n" | ||
| prompts += "\n\n" | ||
| return prompts |
There was a problem hiding this comment.
The type of the return is a prompt string. The name of prompts may cause confusing. Why it is prompts instead of prompt?
kangyu
reviewed
Mar 11, 2024
Comment on lines
89
to
90
| return: The prompt for retrieved documents. | ||
| """ |
There was a problem hiding this comment.
could specify return type, in function definition or comment line.
kangyu
reviewed
Mar 11, 2024
ufo/llm/prompt.py
Outdated
| return prompts | ||
|
|
||
|
|
||
|
|
||
| def api_prompt_helper(apis: dict, verbose: int = 1): |
There was a problem hiding this comment.
May specify return type.
Suggested change
| def api_prompt_helper(apis: dict, verbose: int = 1): | |
| def api_prompt_helper(apis: dict, verbose: int = 1) -> list[str]: |
kangyu
reviewed
Mar 11, 2024
| @@ -33,6 +33,10 @@ Both agents leverage the multi-modal capabilities of GPT-Vision to comprehend th | |||
|
|
|||
|
|
|||
| ## 📢 News | |||
| - 📅 2024-03-XX: New Release for v0.0.1! Check out our exciting new features: | |||
| 1. Our UFO framework now support RAG from offline document and online Bing search. | |||
| 2. We now support creating your help documents for each Windows app to become an app expert. Check XX for more details! | |||
There was a problem hiding this comment.
Is it a missing or TBD as expected?
kangyu
reviewed
Mar 11, 2024
ufo/ui_control/control.py
Outdated
| """ | ||
| Get the application name of the window. | ||
| :param window: The window to get the application name. | ||
| :return: The application name of the window. |
There was a problem hiding this comment.
Suggested change
| :return: The application name of the window. | |
| :return: The application name of the window. Empty string ("") if failed to get the name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.