Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Andarist · 2024-09-27T15:12:58Z

this, I feel, is something that was missed in #57801

Given this code:

type MustBeArray<T extends any[]> = T;

type MustHaveFooBar<T extends { foo: unknown; bar: unknown }> = T;

type Hmm2<T> = T extends { foo: string }[]
  ? T extends { bar: number }[]
    ? MustBeArray<{ [I in keyof T]: MustHaveFooBar<T[I]> }>
    : never
  : never;

The apparent type of this mapped type is ({ bar: number; } & { foo: string; })[] (since #57801 ). So it only makes sense to treat T[I] as access with this numeric constraint for I. In other words, it only makes sense to treat T[I] as accessing an element of an array/tuple

…/tuple intersections constraints

typescript-bot · 2024-09-27T15:13:02Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey · 2024-09-27T16:35:39Z

@typescript-bot test it

typescript-bot · 2024-09-27T16:35:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

src/compiler/checker.ts

typescript-bot · 2024-09-27T16:58:24Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-27T17:03:41Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60084/merge:

Everything looks good!

typescript-bot · 2024-09-27T17:17:15Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,987k (± 0.93%)}	_{192,735k (± 0.01%)}	_~	_192,706k	_192,762k	_{p=0.054 n=6}
_{Parse Time}	_{1.32s (± 0.75%)}	_{1.32s (± 0.64%)}	_~	_1.30s	_1.32s	_{p=0.445 n=6}
_{Bind Time}	_0.72s	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.74s (± 0.46%)}	_{9.74s (± 0.19%)}	_~	_9.72s	_9.77s	_{p=0.936 n=6}
_{Emit Time}	_{2.72s (± 0.63%)}	_{2.73s (± 0.49%)}	_~	_2.71s	_2.75s	_{p=0.366 n=6}
_{Total Time}	_{14.50s (± 0.35%)}	_{14.50s (± 0.16%)}	_~	_14.46s	_14.52s	_{p=0.935 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,995	_{+257 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,083k (± 0.00%)}	_{1,224,135k (± 0.01%)}	_~	_1,224,073k	_1,224,226k	_{p=0.128 n=6}
_{Parse Time}	_{6.62s (± 0.39%)}	_{6.63s (± 0.79%)}	_~	_6.58s	_6.73s	_{p=1.000 n=6}
_{Bind Time}	_{1.88s (± 0.27%)}	_{1.88s (± 0.62%)}	_~	_1.86s	_1.89s	_{p=0.929 n=6}
_{Check Time}	_{31.76s (± 0.22%)}	_{31.74s (± 0.54%)}	_~	_31.55s	_31.95s	_{p=0.936 n=6}
_{Emit Time}	_{15.13s (± 0.27%)}	_{15.16s (± 0.44%)}	_~	_15.09s	_15.28s	_{p=0.629 n=6}
_{Total Time}	_{55.40s (± 0.14%)}	_{55.41s (± 0.37%)}	_~	_55.12s	_55.68s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,038	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,704k (± 0.00%)}	_{2,351,754k (± 0.00%)}	_{+51k (+ 0.00%)}	_2,351,687k	_2,351,808k	_{p=0.045 n=6}
_{Parse Time}	_{9.32s (± 0.31%)}	_{9.32s (± 0.34%)}	_~	_9.26s	_9.35s	_{p=0.627 n=6}
_{Bind Time}	_{2.15s (± 0.39%)}	_{2.16s (± 0.59%)}	_~	_2.14s	_2.18s	_{p=0.352 n=6}
_{Check Time}	_{75.96s (± 0.44%)}	_{75.86s (± 0.44%)}	_~	_75.42s	_76.19s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 1.86%)}	_~	_0.27s	_0.28s	_{p=0.114 n=6}
_{Total Time}	_{87.72s (± 0.36%)}	_{87.62s (± 0.40%)}	_~	_87.18s	_87.96s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,668	_1,250,670	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,081	_265,082	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,406,078k (± 0.03%)}	_{2,406,458k (± 0.02%)}	_~	_2,405,857k	_2,407,020k	_{p=0.298 n=6}
_{Parse Time}	_{5.18s (± 1.13%)}	_{5.21s (± 1.05%)}	_~	_5.12s	_5.28s	_{p=0.230 n=6}
_{Bind Time}	_{1.97s (± 0.59%)}	_{1.97s (± 0.38%)}	_~	_1.96s	_1.98s	_{p=0.734 n=6}
_{Check Time}	_{35.56s (± 0.19%)}	_{35.56s (± 0.58%)}	_~	_35.24s	_35.84s	_{p=0.688 n=6}
_{Emit Time}	_{3.00s (± 2.13%)}	_{3.04s (± 3.86%)}	_~	_2.96s	_3.27s	_{p=0.936 n=6}
_{Total Time}	_{45.73s (± 0.27%)}	_{45.77s (± 0.68%)}	_~	_45.43s	_46.34s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,668	_1,250,670	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,081	_265,082	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,636,919k (±10.47%)}	_{2,747,595k (±12.80%)}	_~	_2,485,047k	_3,201,574k	_{p=0.936 n=6}
_{Parse Time}	_{6.67s (± 1.98%)}	_{6.73s (± 2.66%)}	_~	_6.56s	_7.03s	_{p=0.872 n=6}
_{Bind Time}	_{2.13s (± 0.71%)}	_{2.17s (± 1.77%)}	_~	_2.11s	_2.22s	_{p=0.108 n=6}
_{Check Time}	_{42.97s (± 0.30%)}	_{42.98s (± 0.28%)}	_~	_42.81s	_43.14s	_{p=1.000 n=6}
_{Emit Time}	_{3.33s (± 1.75%)}	_{3.31s (± 2.46%)}	_~	_3.17s	_3.39s	_{p=0.936 n=6}
_{Total Time}	_{55.13s (± 0.37%)}	_{55.19s (± 0.24%)}	_~	_54.96s	_55.34s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,987	_260,989	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,423	_106,424	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,854k (± 0.01%)}	_{436,861k (± 0.01%)}	_~	_436,771k	_436,937k	_{p=0.575 n=6}
_{Parse Time}	_{3.52s (± 0.91%)}	_{3.51s (± 0.53%)}	_~	_3.48s	_3.53s	_{p=1.000 n=6}
_{Bind Time}	_{1.30s (± 2.25%)}	_{1.30s (± 1.81%)}	_~	_1.27s	_1.33s	_{p=0.747 n=6}
_{Check Time}	_{18.89s (± 0.33%)}	_{18.92s (± 0.39%)}	_~	_18.82s	_18.99s	_{p=0.258 n=6}
_{Emit Time}	_{1.48s (± 0.43%)}	_{1.48s (± 1.26%)}	_~	_1.45s	_1.50s	_{p=1.000 n=6}
_{Total Time}	_{25.19s (± 0.33%)}	_{25.21s (± 0.31%)}	_~	_25.09s	_25.29s	_{p=0.688 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,953k (± 0.02%)}	_{370,965k (± 0.01%)}	_~	_370,902k	_371,011k	_{p=0.575 n=6}
_{Parse Time}	_{2.88s (± 1.11%)}	_{2.92s (± 0.52%)}	_~	_2.90s	_2.94s	_{p=0.073 n=6}
_{Bind Time}	_{1.57s (± 1.23%)}	_{1.59s (± 2.06%)}	_~	_1.55s	_1.64s	_{p=0.418 n=6}
_{Check Time}	_{16.29s (± 0.42%)}	_{16.33s (± 0.34%)}	_~	_16.23s	_16.38s	_{p=0.421 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.75s (± 0.29%)}	_{20.83s (± 0.22%)}	_{+0.08s (+ 0.40%)}	_20.77s	_20.89s	_{p=0.045 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,106,060	_3,106,060	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,071,136	_1,071,136	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,200,679k (± 0.00%)}	_{3,200,662k (± 0.00%)}	_~	_3,200,542k	_3,200,767k	_{p=1.000 n=6}
_{Parse Time}	_{14.01s (± 0.26%)}	_{14.01s (± 0.72%)}	_~	_13.92s	_14.21s	_{p=0.420 n=6}
_{Bind Time}	_{4.46s (± 2.50%)}	_{4.74s (±16.89%)}	_~	_4.39s	_6.38s	_{p=1.000 n=6}
_{Check Time}	_{86.80s (± 2.86%)}	_{84.73s (± 2.51%)}	_~	_81.71s	_88.38s	_{p=0.093 n=6}
_{Emit Time}	_{24.58s (± 9.72%)}	_{23.13s (± 7.81%)}	_~	_22.28s	_26.82s	_{p=0.378 n=6}
_{Total Time}	_{129.85s (± 3.57%)}	_{126.62s (± 1.45%)}	_~	_125.25s	_129.11s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,071	_279,071	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,893	_113,893	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,807k (± 0.03%)}	_{428,841k (± 0.04%)}	_~	_428,565k	_429,088k	_{p=0.936 n=6}
_{Parse Time}	_{4.06s (± 1.12%)}	_{4.04s (± 0.75%)}	_~	_3.99s	_4.08s	_{p=0.376 n=6}
_{Bind Time}	_{1.74s (± 1.05%)}	_{1.74s (± 1.58%)}	_~	_1.71s	_1.77s	_{p=1.000 n=6}
_{Check Time}	_{18.05s (± 0.67%)}	_{18.22s (± 0.81%)}	_~	_17.99s	_18.38s	_{p=0.093 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.86s (± 0.60%)}	_{24.00s (± 0.67%)}	_~	_23.78s	_24.21s	_{p=0.090 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,296	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{483,617k (± 0.04%)}	_{483,582k (± 0.03%)}	_~	_483,325k	_483,712k	_{p=0.689 n=6}
_{Parse Time}	_{3.36s (± 0.69%)}	_{3.36s (± 1.16%)}	_~	_3.29s	_3.41s	_{p=1.000 n=6}
_{Bind Time}	_{1.17s (± 1.26%)}	_{1.17s (± 0.89%)}	_~	_1.16s	_1.19s	_{p=0.805 n=6}
_{Check Time}	_{18.97s (± 1.26%)}	_{18.98s (± 1.11%)}	_~	_18.87s	_19.41s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.50s (± 1.07%)}	_{23.51s (± 0.98%)}	_~	_23.33s	_23.97s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-27T18:20:47Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60084/merge:

Something interesting changed - please have a look.

Details

vuejs/core

4 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2349: This expression is not callable.
- packages/reactivity/__tests__/reactiveArray.spec.ts#L253 in tsconfig.json
- packages/reactivity/__tests__/reactiveArray.spec.ts#L266 in tsconfig.json

jakebailey · 2024-09-27T18:57:09Z

Curious how this has the same vue change as #55386

Andarist · 2024-09-27T22:53:48Z

It happens to behave in the same way because the created substitution type has .constraint that is an array/tuple type. In
#55386 getConstraintOfTypeParameter lucked out by reading that property, thinking it reads it from a type parameter but it was reading it from a substation type.

This PR here ends up reading similar information but this time through correct functions. In the case of the substation type getConstraintOfType ends up calling getBaseConstraintOfType.

However, this still boils down to an existing issue: #59260

Andarist added 3 commits September 27, 2024 09:59

Add numeric constraints to type parameters of mapped types with array…

0fb7a70

…/tuple intersections constraints

add extra tests

2c4845d

update baselines

470eccc

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 27, 2024

Andarist mentioned this pull request Sep 27, 2024

Add numeric constraints to type parameters of mapped types with narrowed down array constraints #55386

Draft

jakebailey reviewed Sep 27, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

rename to isArrayOrTupleIntersection

68e95af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Andarist commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

tsc

typescript-bot commented Sep 27, 2024

vuejs/core

tsconfig.json

jakebailey commented Sep 27, 2024

Andarist commented Sep 27, 2024

Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Are you sure you want to change the base?

Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Conversation

Andarist commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 • edited Loading

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

tsc

typescript-bot commented Sep 27, 2024

vuejs/core

tsconfig.json

jakebailey commented Sep 27, 2024

Andarist commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 •

edited

Loading