Revert "Allow variance annotations on generic references (#56418)" #59793

Andarist · 2024-08-29T07:26:56Z

see the comment here, cc @JoshuaKGoldberg @gabritto

…6418)" This reverts commit 41259d5.

Andarist · 2024-08-29T07:28:52Z

tests/baselines/reference/varianceReferences.errors.txt

the new assignability errors (for newly added assignments) are here the same as on main - that's why those variance annotations that were allowed shouldn't be allowed (because they are completely ignored anyway)

gabritto · 2024-08-29T16:54:15Z

@typescript-bot test it

typescript-bot · 2024-08-29T16:54:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-29T17:13:39Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-29T17:16:52Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/59793/merge:

Everything looks good!

typescript-bot · 2024-08-29T17:32:15Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,679k (± 0.90%)}	_{192,951k (± 0.74%)}	_~	_192,310k	_195,874k	_{p=0.092 n=6}
_{Parse Time}	_{1.58s (± 0.48%)}	_{1.57s (± 0.80%)}	_~	_1.55s	_1.58s	_{p=0.301 n=6}
_{Bind Time}	_{0.85s (± 1.05%)}	_{0.85s (± 1.15%)}	_~	_0.84s	_0.87s	_{p=0.931 n=6}
_{Check Time}	_{11.39s (± 0.35%)}	_{11.36s (± 0.37%)}	_~	_11.30s	_11.42s	_{p=0.334 n=6}
_{Emit Time}	_{3.25s (± 0.43%)}	_{3.24s (± 0.32%)}	_~	_3.22s	_3.25s	_{p=0.118 n=6}
_{Total Time}	_{17.07s (± 0.24%)}	_{17.03s (± 0.33%)}	_~	_16.94s	_17.10s	_{p=0.227 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,679k (± 0.00%)}	_{1,222,672k (± 0.00%)}	_~	_1,222,623k	_1,222,741k	_{p=0.689 n=6}
_{Parse Time}	_{7.92s (± 0.77%)}	_{7.91s (± 0.47%)}	_~	_7.86s	_7.96s	_{p=0.809 n=6}
_{Bind Time}	_{2.23s (± 0.23%)}	_{2.23s (± 0.23%)}	_~	_2.23s	_2.24s	_{p=0.069 n=6}
_{Check Time}	_{36.52s (± 0.31%)}	_{36.46s (± 0.39%)}	_~	_36.18s	_36.57s	_{p=0.335 n=6}
_{Emit Time}	_{17.80s (± 0.72%)}	_{17.86s (± 0.81%)}	_~	_17.73s	_18.12s	_{p=0.936 n=6}
_{Total Time}	_{64.47s (± 0.25%)}	_{64.46s (± 0.31%)}	_~	_64.15s	_64.73s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,532,841	_2,532,841	_~	_~	_~	_{p=1.000 n=6}
_Types	_996,405	_996,405	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,460,295k (± 0.00%)}	_{2,460,285k (± 0.00%)}	_~	_2,460,234k	_2,460,415k	_{p=0.873 n=6}
_{Parse Time}	_{11.14s (± 0.26%)}	_{11.13s (± 0.39%)}	_~	_11.08s	_11.19s	_{p=1.000 n=6}
_{Bind Time}	_{2.65s (± 0.28%)}	_{2.64s (± 0.48%)}	_~	_2.62s	_2.65s	_{p=0.301 n=6}
_{Check Time}	_{88.73s (± 0.21%)}	_{88.41s (± 0.13%)}	_{-0.32s (- 0.36%)}	_88.31s	_88.58s	_{p=0.008 n=6}
_{Emit Time}	_{0.34s (± 3.65%)}	_{0.33s (± 2.29%)}	_~	_0.32s	_0.34s	_{p=0.388 n=6}
_{Total Time}	_{102.84s (± 0.19%)}	_{102.51s (± 0.13%)}	_{-0.33s (- 0.33%)}	_102.35s	_102.73s	_{p=0.008 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,232,176	_1,232,176	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,605	_264,605	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,532,583k (±11.78%)}	_{2,414,339k (± 6.02%)}	_~	_2,354,218k	_2,711,318k	_{p=0.810 n=6}
_{Parse Time}	_{6.04s (± 1.14%)}	_{6.04s (± 0.76%)}	_~	_5.98s	_6.12s	_{p=0.809 n=6}
_{Bind Time}	_{2.26s (± 1.28%)}	_{2.27s (± 1.47%)}	_~	_2.24s	_2.33s	_{p=0.747 n=6}
_{Check Time}	_{41.17s (± 0.74%)}	_{41.12s (± 1.12%)}	_~	_40.43s	_41.76s	_{p=0.748 n=6}
_{Emit Time}	_{4.03s (± 1.83%)}	_{4.02s (± 1.18%)}	_~	_3.97s	_4.10s	_{p=0.748 n=6}
_{Total Time}	_{53.51s (± 0.62%)}	_{53.46s (± 0.78%)}	_~	_52.92s	_54.06s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,232,176	_1,232,176	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,605	_264,605	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,429,895k (± 0.02%)}	_{2,429,141k (± 0.02%)}	_{-754k (- 0.03%)}	_2,428,426k	_2,429,526k	_{p=0.031 n=6}
_{Parse Time}	_{7.74s (± 0.66%)}	_{7.75s (± 0.65%)}	_~	_7.69s	_7.81s	_{p=0.575 n=6}
_{Bind Time}	_{2.56s (± 5.32%)}	_{2.61s (± 5.79%)}	_~	_2.49s	_2.82s	_{p=0.686 n=6}
_{Check Time}	_{51.39s (± 0.59%)}	_{51.22s (± 0.59%)}	_~	_50.87s	_51.69s	_{p=0.298 n=6}
_{Emit Time}	_{5.16s (± 4.20%)}	_{5.04s (± 1.01%)}	_~	_4.96s	_5.11s	_{p=0.810 n=6}
_{Total Time}	_{66.84s (± 0.36%)}	_{66.64s (± 0.51%)}	_~	_66.29s	_67.03s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,979	_256,979	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,765	_105,765	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,707k (± 0.01%)}	_{429,663k (± 0.01%)}	_~	_429,638k	_429,735k	_{p=0.054 n=6}
_{Parse Time}	_{4.18s (± 0.32%)}	_{4.17s (± 0.39%)}	_~	_4.15s	_4.19s	_{p=0.139 n=6}
_{Bind Time}	_{1.60s (± 0.73%)}	_{1.59s (± 0.76%)}	_~	_1.57s	_1.60s	_{p=0.438 n=6}
_{Check Time}	_{22.35s (± 0.33%)}	_{22.33s (± 0.60%)}	_~	_22.11s	_22.47s	_{p=1.000 n=6}
_{Emit Time}	_{2.04s (± 0.59%)}	_{2.03s (± 0.97%)}	_~	_2.01s	_2.06s	_{p=0.744 n=6}
_{Total Time}	_{30.17s (± 0.27%)}	_{30.13s (± 0.43%)}	_~	_29.91s	_30.27s	_{p=0.746 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,221k (± 0.01%)}	_{370,210k (± 0.01%)}	_~	_370,172k	_370,284k	_{p=0.378 n=6}
_{Parse Time}	_{2.30s (± 0.51%)}	_{2.30s (± 0.45%)}	_~	_2.28s	_2.31s	_{p=0.615 n=6}
_{Bind Time}	_{1.32s (± 2.02%)}	_{1.32s (± 1.62%)}	_~	_1.30s	_1.36s	_{p=0.452 n=6}
_{Check Time}	_{13.38s (± 0.61%)}	_{13.38s (± 0.40%)}	_~	_13.34s	_13.48s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.00s (± 0.42%)}	_{17.00s (± 0.44%)}	_~	_16.93s	_17.14s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,022,723	_3,022,723	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,039,971	_1,039,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,143,441k (± 0.00%)}	_{3,143,488k (± 0.00%)}	_~	_3,143,435k	_3,143,562k	_{p=0.173 n=6}
_{Parse Time}	_{13.99s (± 0.25%)}	_{13.97s (± 0.28%)}	_~	_13.91s	_14.03s	_{p=0.870 n=6}
_{Bind Time}	_{4.34s (± 2.10%)}	_{4.34s (± 2.06%)}	_~	_4.28s	_4.52s	_{p=0.806 n=6}
_{Check Time}	_{80.64s (± 0.42%)}	_{80.52s (± 0.15%)}	_~	_80.36s	_80.65s	_{p=0.521 n=6}
_{Emit Time}	_{20.58s (± 0.62%)}	_{20.59s (± 0.55%)}	_~	_20.45s	_20.71s	_{p=1.000 n=6}
_{Total Time}	_{119.54s (± 0.36%)}	_{119.42s (± 0.13%)}	_~	_119.22s	_119.60s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_275,318	_275,318	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,432	_112,432	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,226k (± 0.01%)}	_{424,217k (± 0.01%)}	_~	_424,171k	_424,334k	_{p=0.471 n=6}
_{Parse Time}	_{4.90s (± 0.20%)}	_{4.90s (± 0.33%)}	_~	_4.88s	_4.92s	_{p=1.000 n=6}
_{Bind Time}	_{2.12s (± 0.67%)}	_{2.12s (± 1.18%)}	_~	_2.08s	_2.15s	_{p=0.570 n=6}
_{Check Time}	_{21.73s (± 0.28%)}	_{21.64s (± 0.31%)}	_{-0.09s (- 0.41%)}	_21.54s	_21.71s	_{p=0.045 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.75s (± 0.25%)}	_{28.67s (± 0.24%)}	_~	_28.57s	_28.77s	_{p=0.128 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_536,424	_536,424	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,440	_177,440	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{482,023k (± 0.10%)}	_{481,799k (± 0.11%)}	_~	_481,269k	_482,320k	_{p=0.297 n=6}
_{Parse Time}	_{2.84s (± 0.87%)}	_{2.83s (± 0.27%)}	_~	_2.82s	_2.84s	_{p=0.415 n=6}
_{Bind Time}	_{1.05s (± 0.78%)}	_{1.05s (± 0.78%)}	_~	_1.03s	_1.05s	_{p=1.000 n=6}
_{Check Time}	_{15.46s (± 0.21%)}	_{15.46s (± 0.36%)}	_~	_15.39s	_15.56s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.34s (± 0.19%)}	_{19.34s (± 0.30%)}	_~	_19.28s	_19.44s	_{p=0.687 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-29T18:24:00Z

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59793/merge:

Everything looks good!

bgenia · 2024-08-29T20:08:55Z

Will this reopen #56390?

Andarist · 2024-08-29T21:37:13Z

If @RyanCavanaugh keeps the opinion that this is a bug then yes, it should be reopened.

I could alternatively try to fix the assignability issue but it wasn’t clear to me if that should be fixed. So as the first step I decided that it’s better to have the checker rules in a cohesive state by reverting this PR and then hash out the desired behavior for this

gabritto · 2024-09-03T20:40:41Z

@typescript-bot test top800

typescript-bot · 2024-09-03T20:40:45Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	✅ Results

typescript-bot · 2024-09-03T23:01:44Z

@gabritto Here are the results of running the top 800 repos with tsc comparing main and refs/pull/59793/merge:

Everything looks good!

Andarist added 2 commits August 29, 2024 09:20

Revert "Allow variance annotations on generic references (microsoft#5…

c11bc38

…6418)" This reverts commit 41259d5.

add tests back

2381ec9

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 29, 2024

Andarist commented Aug 29, 2024

View reviewed changes

gabritto self-requested a review August 30, 2024 20:36

gabritto self-assigned this Aug 30, 2024

gabritto approved these changes Sep 3, 2024

View reviewed changes

gabritto merged commit 29d92ed into microsoft:main Sep 3, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Allow variance annotations on generic references (#56418)" #59793

Revert "Allow variance annotations on generic references (#56418)" #59793

Andarist commented Aug 29, 2024

Andarist Aug 29, 2024

gabritto commented Aug 29, 2024

typescript-bot commented Aug 29, 2024 •

edited

Loading

typescript-bot commented Aug 29, 2024

typescript-bot commented Aug 29, 2024

typescript-bot commented Aug 29, 2024

tsc

typescript-bot commented Aug 29, 2024

bgenia commented Aug 29, 2024

Andarist commented Aug 29, 2024

gabritto commented Sep 3, 2024

typescript-bot commented Sep 3, 2024 •

edited

Loading

typescript-bot commented Sep 3, 2024

Revert "Allow variance annotations on generic references (#56418)" #59793

Revert "Allow variance annotations on generic references (#56418)" #59793

Conversation

Andarist commented Aug 29, 2024

Andarist Aug 29, 2024

Choose a reason for hiding this comment

gabritto commented Aug 29, 2024

typescript-bot commented Aug 29, 2024 • edited Loading

typescript-bot commented Aug 29, 2024

typescript-bot commented Aug 29, 2024

typescript-bot commented Aug 29, 2024

tsc

typescript-bot commented Aug 29, 2024

bgenia commented Aug 29, 2024

Andarist commented Aug 29, 2024

gabritto commented Sep 3, 2024

typescript-bot commented Sep 3, 2024 • edited Loading

typescript-bot commented Sep 3, 2024

typescript-bot commented Aug 29, 2024 •

edited

Loading

typescript-bot commented Sep 3, 2024 •

edited

Loading