-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LWG-3699 lexically_relative
on UNC drive paths (\\?\C:\...
) results in a default-constructed value
#2867
Fix LWG-3699 lexically_relative
on UNC drive paths (\\?\C:\...
) results in a default-constructed value
#2867
Conversation
Marking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - all I noticed were very minor issues/questions.
@StephanTLavavej fixed :) |
We talked about this at the weekly maintainer meeting and decided that the strategy of "UNC paths can be lexically relative to one another, but not UNC and DOS" is reasonable given the Standard's wording and our behavior here (where we consider |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving filesystem behavior on Windows! 🗄️ 🗂️ 💾 |
…esults in a default-constructed value (microsoft#2867) Co-authored-by: nicole mazzuca <[email protected]>
The output: The “root name” component extracted from the path is reported as an empty string ( The root directory output is |
Fixes #2256 and LWG-3699
This is one choice of how to implement this; it makes
lexically_relative
treat\\?\<drive letter>:\
as equivalent to<drive letter>:\
; another option would just be to allow\\?\<drive letter>:\
and not have them be equivalent.