Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run-UnitConverter] Use capital letters in DegreePrefixer #34845

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PesBandi
Copy link
Contributor

@PesBandi PesBandi commented Sep 12, 2024

Summary of the Pull Request

f and c would previously get converted to °f and °c, now they get converted to °F and °C.
Also removes the FeetToFt() function, as it's not needed anymore

PR Checklist

  • Closes: [Run-UnitConverter] Uses lowercase letters in DegreePrefixer #34842
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

Before:
image
After:
image

Validation Steps Performed

Manually trying it in PTRun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant