-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bot trigger to add Product-Workspaces label to new issues-bugs #34819
Conversation
Co-authored-by: Muhammad Danish <[email protected]>
- isAction: | ||
action: Opened | ||
- bodyContains: | ||
pattern: ### Area\(s\) with issue\?\s*\nWorkspaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#
is interpreted as a comment in YAML, i'm worried if the pattern may fail because of that? Having it without ### would still be a confident match I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could escape with '' but I agree that removing the markdown characters suffices for the pattern. If it over-triggers, we can add the escaped ###
Looking at the size of your policy file, it may also be beneficial to start splitting the triggers into their own files. winget-pkgs is a great example of how multiple files can be used for policies. This really helps when trying to identify what rules are already existing or when debugging why a certain rule is either failing or being triggered too often. For example - you can have one file that contains all the rules for when an issue is opened, another file for the auto-close scheduled searches, and one that handles whenever someone comments. |
Added new policy bot trigger to recognize new Workspaces bugs and label them with Product-Workspaces label. Will expand this to all modules if it works properly.