[#27712] PowerToys New+ v0.1 #33136

cgaarden · 2024-05-29T03:46:09Z

Summary of the Pull Request

This PR contains the first very early version of New+ (#27712)

New+ is a new PowerToys for the File Explorer that enables users to create files and folders from a personalized set of templates.

Issue:
#27712

Spec:
https://1drv.ms/w/s!AgfnseFPEL1w2NklIIJb2hDgHkz6MQ?e=b8rSuL

This PR includes:
• Early version of New+
• New+ Windows 11 File Explorer support
• Dark and Light System Theme support
• Logging + Trace
• New+ GPO settings
• New+ Settings page
• New+ What's new page
• New+ example templaes
• New+ uninstall support

Closes: Create new file from a list of customizable templates straight from the folder context menu #27712
This doesn’t close Create new file from a list of customizable templates straight from the folder context menu #27712 yet
Communication: I've discussed this with core contributors already.
Tests: Added/updated and all pass
Localization: All end user facing strings can be localized
[ X] Dev docs: Added/updated

See also MicrosoftDocs/windows-dev-docs#5065

New binaries: Added on the required places
- JSON for signing for new binaries
- WXS for installer for new binaries and localization folder
- YML for CI pipeline for new test projects

No new test projects yet

YML for signed pipeline

Don't think any changes are required

Documentation updated: If checked, please file a pull request on our docs repo and link it here: [FancyZones] Handle desktop switch and open on active monitor functionality #5065

See also MicrosoftDocs/windows-dev-docs#5065

Detailed Description of the Pull Request / Additional comments

• Added System Theme to ThemeHelper.h/.cpp and renamed AppTheme enum to Theme

Validation Steps Performed

• Ran all unit tests except for UITests-FancyZones, UITests-FancyZonesEditor
• Removed all default settings
• Tested that defaults are same via Settings or just via invoking File Extension for the first time
• Removed new+ template folder
• Removed all items in new+ template folder
• Changed template folder location via settings 
• Changed hide extension via settings
• Changed dark and light system themes
• Basic test of Keyboard manager with different app theme
• Basic test of PowerRename with different app theme
• Toggling New+ via GPO settings
• Installing and uninstalling
• Uninstall only uninstalls example templates, does not uninstall user created templates

Made ThemeRegistryHelper protected

Removed New.wxs from installer

Restored logger_helper.h

Updated resources to have the right white space formatting

Replaced tabs with spaces

Added GPO info to GPO assets and fixed bug while testing GPO support

Added files for signing

htcfreek

Thank you for the contribution.

I made a small comment on the policy name.

src/gpo/assets/PowerToys.admx

cgaarden · 2024-05-29T23:40:44Z

@microsoft-github-policy-service agree

…ddress feedback from htcfreak Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak

using git-bash curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/microsoft/PowerToys/actions/runs/9294625751/attempts/1'

htcfreek

I think it's the best to rename all places (docs, code, directory, installer) where the utility is called "New" to "NewPlus".

New can be read as new item and is confusing then.

src/common/ManagedCommon/ModuleType.cs

src/common/GPOWrapper/GPOWrapper.cpp

src/common/utils/gpo.h

Not fully tested

…templates

installer/PowerToysSetup/PowerToysInstaller.wixproj

installer/PowerToysSetup/NewPlusTemplates.wxs

installer/PowerToysSetup/Product.wxs

stefansjfw · 2024-08-29T12:25:42Z

src/gpo/assets/PowerToys.admx

this file will need revision update - lines 4 and 9

stefansjfw · 2024-08-29T12:25:52Z

src/gpo/assets/PowerToys.admx

@@ -335,6 +335,16 @@
        <decimal value="0" />
      </disabledValue>
    </policy>
+    <policy name="ConfigureEnabledUtilityNewPlus" class="Both" displayName="$(string.ConfigureEnabledUtilityNewPlus)" explainText="$(string.ConfigureEnabledUtilityDescription)" key="Software\Policies\PowerToys" valueName="ConfigureEnabledUtilityNewPlus">
+      <parentCategory ref="PowerToys" />
+      <supportedOn ref="SUPPORTED_POWERTOYS_0_83_0" />


will be 85 probably

stefansjfw · 2024-08-29T12:26:19Z

src/gpo/assets/en-US/PowerToys.adml

revision update - line 4

This reverts commit 6db4a0f.

Bug fix

…into NewPlus-v0.1

htcfreek · 2024-09-12T05:02:40Z

What is required to get this in? Waiting for it.

jaimecbernardo · 2024-09-18T15:12:44Z

Trying to get the branch to build again so we can re-review :)

cgaarden added 13 commits May 26, 2024 13:58

Very early v0.1 of New+

71dfed2

Merge branch 'main' into NewPlus-v0.1

fc2f58d

Update PowerToysInstaller.wixproj

81039dc

Restore installer

35b7ee1

Update theme_helpers.h

db932c3

Made ThemeRegistryHelper protected

Delete New.wxs

6ef1a3f

Removed New.wxs from installer

Update logger_helper.h

5490c65

Restored logger_helper.h

Removing unintended changes after merge

bae2a19

Update Resources.resw

9d951d1

Updated resources to have the right white space formatting

Update Resources.resw

19c5197

Replaced tabs with spaces

Fixed GPO support

27e064f

Added GPO info to GPO assets and fixed bug while testing GPO support

Update ESRPSigning_core.json

738e926

Added files for signing

Removed clang-format

dbff411

cgaarden requested review from crutkas, DHowett and ethanfangg as code owners May 29, 2024 03:46

cgaarden marked this pull request as draft May 29, 2024 03:46

This comment has been minimized.

Sign in to view

htcfreek reviewed May 29, 2024

View reviewed changes

src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved

Update GPO setting name to reference NewPlus rather than just New - A…

af738db

…ddress feedback from htcfreak Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak

This comment has been minimized.

Sign in to view

Added additional words to expect.txt

0e42492

using git-bash curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/microsoft/PowerToys/actions/runs/9294625751/attempts/1'

htcfreek reviewed May 30, 2024

View reviewed changes

src/common/ManagedCommon/ModuleType.cs Outdated Show resolved Hide resolved

src/common/GPOWrapper/GPOWrapper.cpp Outdated Show resolved Hide resolved

src/common/utils/gpo.h Outdated Show resolved Hide resolved

src/common/utils/gpo.h Outdated Show resolved Hide resolved

Jay-o-Way added the Idea-New PowerToy Suggestion for a PowerToy label Jun 2, 2024

cgaarden added 5 commits June 7, 2024 23:28

Initial Installer Changes

c33a84c

Not fully tested

Fixed installer of New+

a72529b

Removed non-used constant and catch if failing to load json state

07e8174

New+ should be disabled by default

cd91840

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

2bb29b3

This comment has been minimized.

Sign in to view

cgaarden added 3 commits August 25, 2024 14:35

NewPlus - Updated handling of Example Templates, and updated example …

e60e527

…templates

NewPlus - Updated handling of Example Templates, and updated example …

7092d52

…templates

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

d2297ce

This comment has been minimized.

Sign in to view

cgaarden and others added 4 commits August 25, 2024 16:11

Spelling: Added wcsncpy to expect.txt

4c5892c

New+ Fixed light and dark mode on explorer context menu

ccd460f

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

251bc01

Fix build - align WIL version

96f8af3

stefansjfw reviewed Aug 29, 2024

View reviewed changes

stefansjfw and others added 8 commits August 29, 2024 14:46

Fix bad merge

ca11ebb

Cleanup vcxproj to fix ARM build

6db4a0f

Revert "Cleanup vcxproj to fix ARM build"

bedb0ff

This reverts commit 6db4a0f.

Cleanup vcxproj to fix ARM build - working one

f2071f8

Revert installer PostBuildEvent

ce23521

Copy example templates also when enabling New+ via Dashboard

8a73961

Bug fix

Merge branch 'NewPlus-v0.1' of https://github.com/cgaarden/PowerToys …

f3c0cbe

…into NewPlus-v0.1

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

4825acc

oliviertassinari mentioned this pull request Sep 5, 2024

[release] v6.0.2 mui/material-ui#43580

Merged

1 task

cgaarden added 5 commits September 5, 2024 17:58

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

af8be7e

Addressing feedback from Stefan - take 1

046dc4c

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

8a2a249

Merge branch 'NewPlus-v0.1' of https://github.com/cgaarden/PowerToys …

0239daa

…into NewPlus-v0.1

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

af2f134

cgaarden and others added 4 commits September 14, 2024 17:24

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

6fba6a8

Merge branch 'main' into pr33136

2b7b1b7

Update GPO files

a57a0d5

Fix building with WinRT

c98b80a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#27712] PowerToys New+ v0.1 #33136

[#27712] PowerToys New+ v0.1 #33136

cgaarden commented May 29, 2024 •

edited

Loading

This comment has been minimized.

htcfreek left a comment

cgaarden commented May 29, 2024

This comment has been minimized.

htcfreek left a comment

This comment has been minimized.

This comment has been minimized.

stefansjfw Aug 29, 2024

stefansjfw Aug 29, 2024

stefansjfw Aug 29, 2024

htcfreek commented Sep 12, 2024

jaimecbernardo commented Sep 18, 2024

[#27712] PowerToys New+ v0.1 #33136

Are you sure you want to change the base?

[#27712] PowerToys New+ v0.1 #33136

Conversation

cgaarden commented May 29, 2024 • edited Loading

Summary of the Pull Request

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

htcfreek left a comment

Choose a reason for hiding this comment

cgaarden commented May 29, 2024

This comment has been minimized.

htcfreek left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

stefansjfw Aug 29, 2024

Choose a reason for hiding this comment

stefansjfw Aug 29, 2024

Choose a reason for hiding this comment

stefansjfw Aug 29, 2024

Choose a reason for hiding this comment

htcfreek commented Sep 12, 2024

jaimecbernardo commented Sep 18, 2024

cgaarden commented May 29, 2024 •

edited

Loading