Tab Selection

[ryanbodrug-microsoft]

Summary of the Pull Request

This PR allows us to tab between the context buttons for each of the results. This is needed to be handled manually because we want to keep the focus on the textbox while the user is tabbing or using the arrow keys. It's not super clear to the user that the row is selected when the context buttons are unselected. We may need a new visual treatment.

Validation Steps Performed

• Made sure tabing forward navigats the buttons correct order.
• Made sure tabbing backward navigates through the buttons in reverse order.
• Made sure tabbing will also select the row itself.
• Verified hitting enter on the row opens the result.
• Verified hitting enter on the context buttons executes the expected command.

[dsrivastavv]

LGTM!

[dsrivastavv]

nit : SelectedIndex might be confusing with a similar variable name in resultsviewmodel. Should we rename it to something like ContextMenuSelectedIndex ?

[ryanbodrug-microsoft]

nit : SelectedIndex might be confusing with a similar variable name in resultsviewmodel. Should we rename it to something like ContextMenuSelectedIndex ?

Thats a good call, I'll update

[arjunbalgovind]

I notice the second entry in the GIF is <ListView .... > of OneNote.exe. I hope that issue is tracked?

[ryanbodrug-microsoft]

I notice the second entry in the GIF is <ListView .... > of OneNote.exe. I hope that issue is tracked?

@arjunbalgovind It's actually not a bug. Thats a window walker result. I had an open OneNote window (Win+N), and copy pasted some xaml from reference. That is the first line of the text. If I click on the result it takes me to this window. Good Eye though. Thanks for calling it out.