Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report Tool] Zip folder can not be created #12966

Merged
merged 6 commits into from
Sep 1, 2021
Merged

[Bug Report Tool] Zip folder can not be created #12966

merged 6 commits into from
Sep 1, 2021

Conversation

mykhailopylyp
Copy link
Contributor

Summary of the Pull Request

What is this about:
For some users desktop path can not be represented as char*. On the other hand, https://github.com/kuba--/zip requires char* as a path for zip folder.

To solve the issue we zip a folder into the temp folder and then copy it to the desktop.

Don't call InstallationFolder::ReportStructure(reportDir); in the debug mode because it takes a lot of time and makes testing in debug mode impossible. Also, updated the cziplib submodule.

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added the Area-Bug Report Tool Issues around the Bug Report Tool from PowerToys label Aug 31, 2021
@mykhailopylyp
Copy link
Contributor Author

@franky920920
Can you build and test it?

@franky920920
Copy link
Contributor

@franky920920
Can you build and test it?

@mykhailopylyp I'll try.

@franky920920
Copy link
Contributor

@mykhailopylyp I've failed to generate the zip file.
image

Debug build log 
'BugReportTool.exe' (Win32): Loaded 'C:\Projects\PowerToys\x64\Debug\BugReportTool\BugReportTool.exe'. Symbols loaded.
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ntdll.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\kernel32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\KernelBase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\apphelp.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\user32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\win32u.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\gdi32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\gdi32full.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\msvcp_win.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ucrtbase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\advapi32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\msvcrt.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\sechost.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\rpcrt4.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\shell32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ole32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\combase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\oleaut32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\version.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\wevtapi.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\imm32.dll'. 
The thread 0x35b0 has exited with code 0 (0x0).
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\windows.storage.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\WinTypes.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\SHCore.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\shlwapi.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ntmarta.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\cryptsp.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\rsaenh.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\cryptbase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\bcryptprimitives.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\bcrypt.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\kernel.appcore.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\clbcatq.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Windows.Web.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Windows.Globalization.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\BCP47Langs.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Winlangdb.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\BCP47mrm.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\uxtheme.dll'. 
Exception thrown at 0x00007FF9ED0D466C in BugReportTool.exe: Microsoft C++ exception: int at memory location 0x000000D91C4FE974.
The thread 0x7390 has exited with code 1 (0x1).
The thread 0x7134 has exited with code 1 (0x1).
The thread 0x6058 has exited with code 1 (0x1).
The program '[7556] BugReportTool.exe' has exited with code 1 (0x1).

@mykhailopylyp
Copy link
Contributor Author

@franky920920
Thank you for following up! Can you try to run it again? I expect it to fail but I added some logging.

@franky920920
Copy link
Contributor

franky920920 commented Sep 1, 2021 •
edited
Loading

@mykhailopylyp I've got an empty output after the update. Log file has been successfully generated. (PowerToysReport_2021-09-01-08-17-44.zip)
image

Debug Build log 
'BugReportTool.exe' (Win32): Loaded 'C:\Projects\PowerToys\x64\Debug\BugReportTool\BugReportTool.exe'. Symbols loaded.
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ntdll.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\kernel32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\KernelBase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\user32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\win32u.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\gdi32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\gdi32full.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\msvcp_win.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ucrtbase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\advapi32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\msvcrt.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\sechost.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\rpcrt4.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\shell32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ole32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\combase.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\oleaut32.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\version.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\wevtapi.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\imm32.dll'. 
The thread 0x5c98 has exited with code 0 (0x0).
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\windows.storage.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\WinTypes.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\SHCore.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\shlwapi.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\ntmarta.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\kernel.appcore.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\bcryptprimitives.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\clbcatq.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Windows.Web.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Windows.Globalization.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\BCP47Langs.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\Winlangdb.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\BCP47mrm.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\uxtheme.dll'. 
'BugReportTool.exe' (Win32): Loaded 'C:\Windows\System32\msxml6.dll'. 
The thread 0x5638 has exited with code 0 (0x0).
The thread 0x7d18 has exited with code 0 (0x0).
The thread 0x384c has exited with code 0 (0x0).
The program '[16800] BugReportTool.exe' has exited with code 0 (0x0).

@mykhailopylyp
Copy link
Contributor Author

@franky920920
Just to clarify, how have you tested it? Have you built PowerToys\tools\BugReportTool\BugReportTool.sln and run it?

By the way, can you confirm that bug report from 0.43 version still fails?

@franky920920
Copy link
Contributor

franky920920 commented Sep 1, 2021 •
edited
Loading

@franky920920
Just to clarify, how have you tested it? Have you built PowerToys\tools\BugReportTool\BugReportTool.sln and run it?

Yes. That's how I build it.

By the way, can you confirm that bug report from 0.43 version still fails?

Confirmed that is still failing.

SeraphimaZykova
SeraphimaZykova approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mykhailopylyp mykhailopylyp merged commit f075099 into microsoft:master Sep 1, 2021
@mykhailopylyp mykhailopylyp deleted the issue-12707 branch September 1, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

@SeraphimaZykova SeraphimaZykova SeraphimaZykova approved these changes

Assignees
No one assigned
Labels
Area-Bug Report Tool Issues around the Bug Report Tool from PowerToys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykhailopylyp @franky920920 @yuyoyuppe @SeraphimaZykova