Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][WindowWalker Plugin] Display the application icon for a running process #7770

Open
garrulinae opened this issue Nov 2, 2020 · 16 comments
Assignees
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface Status-In progress This issue or work-item is under development

Comments

@garrulinae
Copy link

garrulinae commented Nov 2, 2020

Now that we can use PT Run as just a window walker (thanks devs!) it would be useful to quickly visually identify running programs by their icons.

Currently a generic icon is used for all running processes, which means that the user has to read the text to figure out which (if any) window is the one they are looking for. Otherwise they have to keep typing (with no typos) to narrow down the query results.

The point of the window walker is to be faster than Alt+Tab, so speed is crucial.

I would like to request that the relevant application icon is used instead of the generic one. Even better – if feasible – use tab icon for each open tab in a browser.

Below are some mockups to illustrate the problem and suggested solution:

mockup


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Nov 2, 2020
@garrulinae
Copy link
Author

garrulinae commented Nov 2, 2020

P.S. In hindsight, my mockups don't really indicate the extent of the problem - I just made some simple visuals to communicate the idea. I should have chosen a better example.

To see how effective this would be, actually input a few characters (with the < selector) into PT Run and view the suggestions - you'll probably agree that the icons would make a huge usability improvement

@crutkas
Copy link
Member

crutkas commented Nov 5, 2020

I think this would be a good idea, but i feel like we need a way to show clearly a running app versus a general app

@crutkas
Copy link
Member

crutkas commented Nov 5, 2020

@betsegaw did you ever look at this? I feel like this plus an additional overlay of somehow showing it is a running process would be massive

@crutkas crutkas added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface Idea-Enhancement New feature or request on an existing product Help Wanted We encourage anyone to jump in on these and submit a PR. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 5, 2020
@crutkas
Copy link
Member

crutkas commented Nov 5, 2020

I feel like we are tracking this

@crutkas
Copy link
Member

crutkas commented Nov 5, 2020

Yup, we do. #2390. Lets close that and track it here.

base on @betsegaw, Looks like code may already be there but we need some little bit of additional edge case / work to get it to the finish line:

There is already code in Window walker to enable this and we can pass it through the results. However, the problem with it right now is that it needs admin permissions to show the icon for certain windows. Is that okay from a cleanliness perspective? Sending a blank icon.

Also, we need to have something that helps people differentiate active windows vs. launches. Should we add a string to the result?

@aarontx
Copy link

aarontx commented Nov 11, 2020

Would it also be possible to have an option to have Active Processes float to the top of the search?

@betsegaw
Copy link
Contributor

@crutkas - below is the link in the old Window class. Not sure when it was removed post transition in the ported class.

https://github.com/betsegaw/windowwalker/blob/6aa7354622555b3fa2c396e8372abfc556966be9/Window%20Walker/Window%20Walker/Components/Window.cs#L141

@enricogior enricogior changed the title PowerToys Run: display the application icon for a running process [Run][WindowWalker Plugin] Display the application icon for a running process Jan 7, 2021
@htcfreek
Copy link
Collaborator

If we implement this it should be an optional setting.

@josefblaha
Copy link

I would like to pick this up. Let's agree on some specs:

  • Show window icon in the results. If not accessible, fallback to executable icon, then to the generic icon (shown now).
  • No icon overlay for now. The results are distinguished by subtitle anyway.
  • Add a setting to opt-out of showing icon.

Is that fine for a MVP? Or would you like to make it opt-in to get some feedback first?

@htcfreek
Copy link
Collaborator

I would like to pick this up. Let's agree on some specs:

  • Show window icon in the results. If not accessible, fallback to executable icon, then to the generic icon (shown now).
  • No icon overlay for now. The results are distinguished by subtitle anyway.
  • Add a setting to opt-out of showing icon.

Is that fine for a MVP? Or would you like to make it opt-in to get some feedback first?

Sounds good. I personally don't have any preference about the the setting.

@crutkas
Copy link
Member

crutkas commented Sep 11, 2022

This we should do a speed test for if opt in vs out

@josefblaha
Copy link

This we should do a speed test for if opt in vs out

Sorry, but I don't understand. What speed test? Should I do anything?

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 13, 2022

This we should do a speed test for if opt in vs out

Sorry, but I don't understand. What speed test? Should I do anything?

I think @crutkas means you should check what query times (See PT Run log file.) you have with and without application icons. And if the results are much slower with icons we should have an opt-in setting.

@marpe
Copy link

marpe commented Sep 12, 2023

Made an attempt here, should I open a PR?

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 13, 2023

Made an attempt here, should I open a PR?

@marpe
Yes please. Your contribution is welcome.

@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Sep 13, 2023
marpe added a commit to marpe/PowerToys that referenced this issue Sep 13, 2023
…ng process

* Display the application icon for a running process in the search results (microsoft#7770)

* Add a setting to opt-out of showing icon

* Adapt tests
@kakins
Copy link

kakins commented Sep 14, 2024

Any news on this one? I saw a commit from a year ago but no more movement. Having the icon in window walker would be a very helpful visual indicator to help navigate open processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface Status-In progress This issue or work-item is under development
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

8 participants