Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when previewing images with Peek #33593

Open
daverayment opened this issue Jul 2, 2024 · 2 comments
Open

Memory leak when previewing images with Peek #33593

daverayment opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-Reproducible This issue was reproduced by a maintainer

Comments

@daverayment
Copy link
Contributor

Microsoft PowerToys version

0.81.1

Installation method

PowerToys auto-update

Running as admin

No

Area(s) with issue?

Peek

Steps to reproduce

  1. Navigate to a folder containing a selection of images. (The bug seems to occur with any number of images in the folder.)
  2. Click on any image and use the Ctrl+Space shortcut to open Peek.
  3. Use the arrow keys to navigate through the images in the folder.

✔️ Expected Behavior

Peek navigates through the images contained within the folder and uses a reasonable amount of memory, related to the size of the individual images being previewed. Subsequent navigations through the same images use the same amount of memory, i.e. the maximum memory used for previewing the folder images does not increase.

❌ Actual Behavior

The memory used by the application increases and is never reclaimed, leading to increased memory pressure on the system.

When the first image is displayed, the tool uses ~150MB:

image

After navigating through 500 images using the arrow keys, the tool uses ~1.4GB:

image

Some notes:

  1. Closing the tool does not free up the used memory.
  2. Leaving the system idle does not free up the used memory (I waited 30 minutes).
  3. Using Peek again after closing it does not free up the used memory.
  4. I am using default settings and PowerToys is running in User mode.

Bug report logs: PowerToysReport_2024-07-02-12-19-16.zip

Other Software

No response

@daverayment daverayment added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@crutkas
Copy link
Member

crutkas commented Jul 2, 2024

I can repro this. Takes a bit with images but got it up to over 300mb and held. Quick glance at code "looks" like it does clean up but clearly it doesn't seem to.

We should validate all file times depending on fix

@crutkas crutkas added Priority-1 Bug that is high priority Status-Reproducible This issue was reproduced by a maintainer Product-Peek Refers to Peek Powertoys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 2, 2024
@crutkas crutkas modified the milestones: PowerToys 0.84, PowerToys 0.83 Jul 2, 2024
@drawbyperpetual drawbyperpetual self-assigned this Aug 14, 2024
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Aug 15, 2024
@drawbyperpetual drawbyperpetual removed the Status-In progress This issue or work-item is under development label Aug 27, 2024
@jaimecbernardo jaimecbernardo added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-Reproducible This issue was reproduced by a maintainer
Projects
Status: No status
Development

No branches or pull requests

6 participants