Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image Resizer] Better support for HEiC image formats #1934

Open
stewartmhome1 opened this issue Apr 4, 2020 · 9 comments
Open

[Image Resizer] Better support for HEiC image formats #1934

stewartmhome1 opened this issue Apr 4, 2020 · 9 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Image Resizer Things regarding image resizing module
Milestone

Comments

@stewartmhome1
Copy link

Can HEIC images be catered for in ImageResizer

@crutkas crutkas added the Product-Image Resizer Things regarding image resizing module label Apr 4, 2020
@crutkas
Copy link
Member

crutkas commented Apr 4, 2020

@bricelam I know you were looking into this Before. Ideas?

@bricelam
Copy link
Contributor

bricelam commented Apr 4, 2020

AFAIK, it should work if you have a WIC codec installed. Needs #1929 for the best experience

@crutkas
Copy link
Member

crutkas commented Apr 4, 2020

Maybe we prompt for “you need to install ....” for heic stuff If they don’t.

@drew-hoffman
Copy link

I came here looking for heic support too. So many web services don't support it yet, it would be great if I could right click -> resize it into a JPEG file in one click.

I have the Microsoft HEIF codec installed already, and can open the images fine in Paint and Preview, but I don't see any shell support for resizing.

@bricelam
Copy link
Contributor

@drew-hoffman One trick you can use is to select both the HEiC image and a dummy JPEG image. This should allow the context menu to show up.

@crutkas
Copy link
Member

crutkas commented Apr 13, 2020

I think we can do better with HEIC, I think it is

  1. if HEIC is installed, enabled for right click
  2. In Settings, detect if file system has any HEIC files and if HEIC ext not is installed.
    1. Add prompt to suggest to install if this case is met.

@crutkas crutkas added this to the Backlog milestone Apr 13, 2020
@crutkas crutkas changed the title HEiC image formats Better support for HEiC image formats Apr 13, 2020
@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Apr 13, 2020
@stamminator
Copy link

I used @bricelam's trick to resize one HEIC file and one JPG file, but the HEIC failed.

image

I already have the HEIF Image Extensions "app" installed from the store, which I assume means I have the necessary codec.

@crutkas crutkas modified the milestones: Backlog, Help Wanted Sep 14, 2020
@enricogior enricogior changed the title Better support for HEiC image formats [Image Resizer] Better support for HEiC image formats Mar 6, 2021
@weyCC81
Copy link

weyCC81 commented Jun 4, 2022

Please add support for HEIC, the resize workaround with a dummy file did not work fully as the files is corrupted afterwards.

@bricelam
Copy link
Contributor

bricelam commented Jun 7, 2022

I dug into the Object reference not set to an instance of an object error once, and it appears to be related to a bug in WPF when it tries to initialize a store-installed codec. I think I "submitted feedback" somewhere for it, but it probably just got lost in the void.

Porting to WinUI/WinAppSDK (#1053) would be one way work around the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Image Resizer Things regarding image resizing module
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

6 participants