Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port 2.1] Hide part of code behind feature flag (#22529) #22539

Conversation

tyler-cai-microsoft
Copy link
Contributor

Original: #22529
Part of a hotfix

There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.

Part of a hotfix

There is some minimum sequence number shenanigans going on. Not exactly
sure, but we want to be able to safely turn off the feature.
@github-actions github-actions bot added area: runtime Runtime related issues base: release PRs targeted against a release branch labels Sep 16, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +568 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 456.97 KB 457.08 KB +116 Bytes
azureClient.js 554.74 KB 554.86 KB +131 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.18 KB 258.27 KB +93 Bytes
fluidFramework.js 405.94 KB 405.95 KB +14 Bytes
loader.js 134.04 KB 134.05 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 145.61 KB 145.62 KB +7 Bytes
odspClient.js 522.88 KB 523.01 KB +130 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 162.62 KB 162.63 KB +7 Bytes
sharedTree.js 396.45 KB 396.46 KB +7 Bytes
Total Size 3.29 MB 3.29 MB +568 Bytes

Baseline commit: 1571e0c

Generated by 🚫 dangerJS against b24f545

@frankmueller-microsoft
Copy link

Approved patch

@frankmueller-microsoft frankmueller-microsoft merged commit f1c23fc into microsoft:release/client/2.1 Sep 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: release PRs targeted against a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants