Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to ConsensusQueue in handle validation tests #22531

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Abe27342
Copy link
Contributor

Description

Modifies ConsensusQueue's generic "store a piece of data" implementation in handleValidation.ts to give more information on a couple theoretical error methods. This test timed out on a recent tinylicious run where based on telemetry, it seems like the test got past the point of loading the 2nd container. Thus it was likely a deadlock awaiting this promise. I've been unable to reproduce this behavior locally. The goal here is to get information about the failure mode the next time this race condition happens.

Copy link
Contributor

@jzaffiro jzaffiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Abe27342 Abe27342 enabled auto-merge (squash) September 16, 2024 21:55
@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Sep 16, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.93 KB 460.96 KB +35 Bytes
azureClient.js 559.03 KB 559.08 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.68 KB 261.69 KB +14 Bytes
fluidFramework.js 401.58 KB 401.6 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 146.64 KB 146.65 KB +7 Bytes
odspClient.js 526.18 KB 526.23 KB +49 Bytes
odspDriver.js 97.8 KB 97.82 KB +21 Bytes
odspPrefetchSnapshot.js 42.76 KB 42.78 KB +14 Bytes
sharedString.js 163.32 KB 163.33 KB +7 Bytes
sharedTree.js 392.05 KB 392.05 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: d45e3ea

Generated by 🚫 dangerJS against ae75729

@Abe27342 Abe27342 merged commit 21288ba into microsoft:main Sep 16, 2024
28 checks passed
@Abe27342 Abe27342 deleted the add-test-diagnostics branch September 16, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants