Commits on May 21, 2024

1. More aggressive reassociations …

   Although DXC applied the upstream change, Reassociate: add global reassociation algorithm (llvm/llvm-project@b8a330c) in this PR (#6598), it still might overlook some obvious common factors.
   
   One case has been observed is:
     %Float4_0   = call %dx.types.CBufRet.f32 @dx.op.cbufferLoadLegacy.f32(i32 59, %dx.types.Handle %1, i32 1)
     %Float4_0.w = extractvalue %dx.types.CBufRet.f32 %Float4_0, 3
     %Float2_0   = call %dx.types.CBufRet.f32 @dx.op.cbufferLoadLegacy.f32(i32 59, %dx.types.Handle %1, i32 0)
     %Float2_0.y = extractvalue %dx.types.CBufRet.f32 %Float2_0, 1
   
     /* %Float4_1 is redundant with %Float4_0 since they invokes cbufferLoadLegacy with same parameters */
     %Float4_1   = call %dx.types.CBufRet.f32 @dx.op.cbufferLoadLegacy.f32(i32 59, %dx.types.Handle %1, i32 1)
   
     /* %Float4_1.w is redundant with %Float4_0.w */
     %Float4_1.w = extractvalue %dx.types.CBufRet.f32 %Float4_1, 3
   
     /* %Float2_1 is redundant with %Float2_0 since they invokes cbufferLoadLegacy with same parameters */
     %Float2_1   = call %dx.types.CBufRet.f32 @dx.op.cbufferLoadLegacy.f32(i32 59, %dx.types.Handle %1, i32 0)
   
     /* %Float2_1.y is redundant with %Float2_0.y */
     %Float2_1.y = extractvalue %dx.types.CBufRet.f32 %Float2_1, 1
   
     ....
     %11 = fmul fast float %Float4_0.w, %10
     %12 = fmul fast float %11, %Float2_0.y
     ....
     %14 = fmul fast float %Float4_1.w, %13
     %15 = fmul fast float %14, %Float2_1.y
   
   (%Float4_0.w * %Float2_0.y) equals to (%Float4_1.w * %Float2_1.y), they should be reassociated to a common factor
   
   The upstream change can't identify this common factor because DXC doesn't know (%Float4_0.w, %Float4_1.w) and (%Float2_0.y, %Float2_1.y) are redundant when running Reassociate pass. Those redundancies will be eliminated in GVN pass.
   
   For DXC can identify more common factors, this PR will aggressively run Reassociate pass again after GVN pass and then run GVN pass again to remove the redundancies generared in this run of Reassociate pass.
   
   Changing the order of floating point operations causes the precision issue. In case some shaders get unexpected results due to this PR, use "-opt-disable aggressive-reassociation" to disable this PR and roll back.
   
   This is part 3 of the fix for #6593.

   

   lizhengxing committed May 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b052e1b
   • Browse repository at this point

   Copy the full SHA

   b052e1b View commit details

   Browse the repository at this point in the history