bug fixes #1656 #1684
bug fixes #1656 #1684
Conversation
|
Why do you need to stop looking in to Unity folder? It's just not going to find file there and move on to next location. AirSim first looks for settings in executable folder and if not found then in to user folder. This is needed so that you can deploy different config for different packaged projects. |
|
All references in the documentation point to placing your settings.json file in the Documents/AirSim directory. There have been some issues brought up about the settings.json file location in unity, so it seems the most foolproof way to stop unexpected behavior for users is to force AirSim to only look in one location. I'll remove the section of the commit related to #1579 , but we should update the docs to inform users that AirSim will look in the executable directory first. |
| @@ -126,8 +126,6 @@ void SimHUD::createSimMode() | |||
| bool SimHUD::getSettingsText(std::string& settingsText) | |||
| { | |||
| return ( | |||
| readSettingsTextFromFile(msr::airlib::Settings::getExecutableFullPath("settings.json"), settingsText) | |||
There was a problem hiding this comment.
Why do you need to stop looking in to Unity folder? It's just not going to find file there and move on to next location. AirSim first looks for settings in executable folder and if not found then in to user folder. This is needed so that you can deploy different config for different packaged projects.
msb336
force-pushed
the
unity-settings-fix
branch
from
777552b
to
c127e2f
Compare
Stops AirSim from looking inside of the unity executable folder for settings.json file and removes the need to have cmake installed globally on your machine.