Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoltDB Depot serial number changes for data races #190

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jessepeterson
Copy link
Member

Changes a few things to make serial number generation make a bit more sense. This brings the implementation in line with the following statements:

Depot.Serial() should always generate a unique new serial number. It's up to Depot.Put() to use the serial number in the generated certificate for storage, minding that there may very well be sequence gaps.

To that end adjust a bunch of things to make it conform to this. Add a mutex in case Serial() is called multiple times concurrently. Fix a few other unrelated things along the way. See also #185 for more context.

…r req. also undo locking done in micromdm#185 in lieu of this fix
@jessepeterson jessepeterson merged commit ab5ddac into micromdm:main Dec 1, 2023
6 checks passed
@jessepeterson jessepeterson deleted the boltdb-serial-changes branch December 1, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant