Skip to content

Commit

Permalink
shared_lib: add as_needed to the libspdk.so linker script
Browse files Browse the repository at this point in the history
specifying as_needed in the linker script prevents us from creating more
runtime dependencies than necessary for a given application linking to
libspdk.so

Change-Id: Ifd3788e210c5e6a0e19749cb575c3dfb494a41d2
Signed-off-by: Seth Howell <[email protected]>
Reviewed-on: https://review.gerrithub.io/427808
Tested-by: SPDK CI Jenkins <[email protected]>
Chandler-Test-Pool: SPDK Automated Test System <[email protected]>
Reviewed-by: Shuhei Matsumoto <[email protected]>
Reviewed-by: Lance Hartmann <[email protected]>
Reviewed-by: Jim Harris <[email protected]>
Reviewed-by: Ben Walker <[email protected]>
  • Loading branch information
Seth5141 authored and jimharris committed Oct 9, 2018
1 parent 89ef215 commit 346fefc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shared_lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ SPDK_SHARED_LIBS := $(filter-out $(IGNORED_LIBS), $(sort $(notdir $(wildcard $(S

$(SHARED_REALNAME_LIB):
$(Q)echo " SO $(notdir $@)"; \
echo "GROUP ( $(SPDK_SHARED_LIBS) )" > $(SHARED_REALNAME_LIB)
echo "GROUP ( AS_NEEDED ( $(SPDK_SHARED_LIBS) ) )" > $(SHARED_REALNAME_LIB)

$(SHARED_LINKED_LIB) : $(SHARED_REALNAME_LIB)
$(Q)echo " SYMLINK $(notdir $@)"; $(BUILD_LINKERNAME_LIB)
Expand Down

0 comments on commit 346fefc

Please sign in to comment.