Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if running in AWS before initializing #28

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

loganm27
Copy link

@loganm27 loganm27 commented Nov 12, 2020

Resolves #27

@ctrimble
Copy link
Contributor

@loganm27 my apologies for missing this back in November. I took a look at the PR and MULTI_PING. I think I understand what you are trying to achieve.

I am happy to get support for this use case in the project. I have a couple of concerns:

  1. In cases where this is the only PING being used and it is not being used in AWS, this PING implementation will init instead of just failing and the only signal will be a log at level debug and I assume a bunch of NPEs getting thrown.
  2. In the case where you are using this with MULTI_PING and you are outside of AWS, it seems like you would again get tons of NPEs happening.

I wonder if the implementation needs a lenient flag and when that is in effect, the implementation detects not being in AWS, logs at info that it is not in AWS, and just NOOPs from that point forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MULTI_PING
2 participants