Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact Chrome versions for 3 CSS properties #3652

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Mar 18, 2019

This is based on the results of generated tests run against Chrome
16-57 on Windows:
https://github.com/foolip/mdn-bcd-results/tree/d113c9dd588915fe8d4c5f9d8180ac333a0dc31a

The tests are generated by https://github.com/foolip/mdn-bcd-collector
and simply check 'columnFill' in document.body.style and similar.

An unweildy script was used to pick these long hanging fruits/changes:
https://gist.github.com/foolip/dcffd93594d71a4cda304061d4b96942

chromestatus.com agrees about column-fill:
https://www.chromestatus.com/feature/6298909664083968

This is based on the results of generated tests run against Chrome
16-57 on Windows:
https://github.com/foolip/mdn-bcd-results/tree/d113c9dd588915fe8d4c5f9d8180ac333a0dc31a

The tests are generated by https://github.com/foolip/mdn-bcd-collector
and simply check `'columnFill' in document.body.style` and similar.

An unweildy script was used to pick these long hanging fruits/changes:
https://gist.github.com/foolip/dcffd93594d71a4cda304061d4b96942

chromestatus.com agrees about column-fill:
https://www.chromestatus.com/feature/6298909664083968
@foolip
Copy link
Collaborator Author

foolip commented Mar 18, 2019

@jpmedley can you help review? I only have data for Chrome on Windows now, but it's very likely that these were also shipped in the same versions of Chrome for Android and WebView.

This is the sort of PR that could be created automatically eventually. Feedback on what information would be useful to include then would be appreciated.

@ddbeck ddbeck added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 18, 2019
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as chromestatus and caniuse seem to agree with this.

@Elchi3 Elchi3 merged commit f36f652 into mdn:master Mar 27, 2019
@foolip foolip deleted the chrome-exact-versions branch March 27, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants