Added lints for ERB templates

[igor-alexandrov]

This PR adds lints to the ERB templates. Yes, erblint is not perfect, however currently it is the only solution that exists and works.

I fixed existing errors and added erblint step to the CI.

[zachgoll]

Thanks for the cleanup! Just left a few potential suggestions.

[zachgoll]

Could we keep this all in a single lint job with multiple steps to lint Ruby and ERB?

Also, is there a reason we're not calling ./bin/erblint --lint-all?

[igor-alexandrov]

@zachgoll I merged two tasks into one. I prefer calling ./bin/erblint ./app/**/*.erb because of explicitness, but --lint-all also makes sense, updated.

[zachgoll]

What do you think of adding a .erb-lint.yml file for a bit more explicitness and integrating with our Rubocop setup?

EnableDefaultLinters: true
linters:
  Rubocop:
    enabled: true
    rubocop_config:
      inherit_from:
        - .rubocop.yml

[igor-alexandrov]

@zachgoll Yes, I forget about the config for the erblint. At the same time, I am completely against enabling all Rubocop rules for erblint. I tried doing this locally, and I got about 3500 errors with only 3000 auto-correctable. Besides this, some HTML tags started to look really strange after the automatic correction.

[igor-alexandrov]

I added .erb-lint.yml, please check.

[zachgoll]

Sounds good, and very understandable on the rubocop integration. I'm all for auto checks, but not if it's going to slow us down too much.

[zachgoll]

Looks good! Thanks again for the cleanup 👍

[zachgoll]

@igor-alexandrov looks like the --lint-all picked up vendor code. Could probably add to the config:

exclude:
  - '**/vendor/**/*'

??

[igor-alexandrov]

erblint can be tricky. I prefer to have a very explicit call that will only lint files inside of an ./app folder.

[adrienpoly]

Very nice addition

with the linters growing in the CI (in the future we could have i18n-tasks, eslint etc) I usually add to my project a small utility to run them all in a single command

something like that in bin/lint

#!/usr/bin/env bash

# Exit when any command fails
set -e

# Check Ruby code formatting
echo "Checking Ruby code formatting..."
bundle exec rubocop -A

# Check erb file formatting
echo "Checking erb file formatting..."
bundle exec erblint --lint-all --autocorrect

[igor-alexandrov]

@adrienpoly I will open a new PR for this. Thank you for this suggestion.