Finish remaining transaction filters #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Sep 16, 2024
| when "greater" | ||
| query = query.where("ABS(account_entries.amount) > ?", params[:amount].to_f.abs) | ||
| end | ||
| end |
There was a problem hiding this comment.
If we have to add more filters in the future, this is definitely a refactor candidate, but given this is the final set of filters for a while, no need right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced transaction filtering a while back, but a few of the filters were not ready to be implemented.
This PR completes the remaining "coming soon" transaction filters so users have full control over their transactions dashboard.