Rubocop updates #1118
Merged
Rubocop updates #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Aug 23, 2024
|
|
||
| Layout/SpaceInsidePercentLiteralDelimiters: | ||
| Enabled: true |
There was a problem hiding this comment.
The Rails omakase config disables this one and prefers %i[ items with space ].
That said, there is no Cop rule that can enforce this. Given the OSS nature of this project, consistency is the most important thing; hence adding this rule in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional code changes here; just formatting and linting due to changing a few Rubocop rules and running
rubocop -aon the codebase..editorconfigwith a minimal set of rules (no tabs, 2 spaces)In general, we'll stay away from adding too many Rubocop rules, but enforcing 2 spaces is helpful