Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD support and export WOW class as default #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cusspvz
Copy link

@cusspvz cusspvz commented May 11, 2016

Implementation referred on issue #228

@cusspvz
Copy link
Author

cusspvz commented May 11, 2016

@graingert Really? Didn't knew about that, didn't code on CS for about probably a year. Is there any easier change?

Inspite it does or not, this does the job.

@samhavens
Copy link

Is this why I have to write

import container from 'wowjs';
const WOW = container.WOW;

...when using WOW through NPM/Browserify?

@graingert
Copy link
Contributor

@samhavens nope, you only need to write:

import Wow from 'wow.js';
new Wow(...);

@graingert
Copy link
Contributor

@samhavens you're missing the "." between wow and js. This gets you the official https://wow.js.org version.

@samhavens
Copy link

So you npm install works, but when you bring it in, you use the period? Or
did I install some alternate version?
On Fri, Jul 22, 2016 at 10:06 AM Thomas Grainger [email protected]
wrote:

@samhavens https://github.com/samhavens nope, you only need to write:

import Wow from 'wow.js';new Wow(...);


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#249 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5W5TqlMARHJccRO8twfCxGQSy-Mz1sks5qYPiNgaJpZM4Icdgp
.

Sam Havens CTO
mobile: 818.590.0484
address: 23480 Park Sorrento 125B | Calabasas, CA 91302
web: carlabs.com
email: [email protected]

@graingert
Copy link
Contributor

graingert commented Jul 22, 2016

@samhavens you need to npm install --save wow.js

@graingert
Copy link
Contributor

when you drop the "." you have to release your source under the GPL.

@samhavens
Copy link

Wow! Thanks
On Fri, Jul 22, 2016 at 10:08 AM Thomas Grainger [email protected]
wrote:

@samhavens https://github.com/samhavens you need to npm install --save
wow.js


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#249 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5W5RXgGYsv8zqb1Y0hYYwv7nwm2TOUks5qYPkYgaJpZM4Icdgp
.

Sam Havens CTO
mobile: 818.590.0484
address: 23480 Park Sorrento 125B | Calabasas, CA 91302
web: carlabs.com
email: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants