Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server name instead of homeserver url to allow well-known lookups during QR OIDC reciprocation #4233

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Use server name instead of homeserver url to allow well-known lookups during QR OIDC reciprocation #4233

merged 5 commits into from
Jun 18, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 7, 2024

No description provided.

@t3chguy
Use server name instead of homeserver url to allow well-known lookups…
11c3338 
… during QR OIDC reciprocation

Signed-off-by: Michael Telatynski <[email protected]>
t3chguy added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 7, 2024
@t3chguy
Dummy PR to Netlify matrix-org/matrix-js-sdk#4233
a0f2be8 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy self-assigned this Jun 7, 2024
@t3chguy
Iterate
116a9f3 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
36b7c1d 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
b2aa2b6 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
e347dca 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review June 17, 2024 13:39
@t3chguy t3chguy requested review from a team as code owners June 17, 2024 13:39
andybalaam
andybalaam approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but is there something you can link to that explains the need for this?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 17, 2024

The MSC changed, so this updates the implementation. matrix-org/matrix-spec-proposals#4108
The requirement was driven by Element X's inability to locate the required sliding proxy on a homeserver url, given the proxy details live on the well-known hosted at the server_name.

@andybalaam
Copy link
Contributor

The MSC changed, so this updates the implementation. matrix-org/matrix-spec-proposals#4108

For reference, matrix-org/matrix-spec-proposals@87f8317 (#4108) - right?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 17, 2024

Yes

hughns
hughns approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t3chguy t3chguy added this pull request to the merge queue Jun 18, 2024
Merged via the queue into develop with commit c55289e Jun 18, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/oidc-qr-server-name branch June 18, 2024 13:25
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 19, 2024
@t3chguy
Remove unused state fields in qr oidc (#12588)
a4af287 
* Dummy PR to Netlify matrix-org/matrix-js-sdk#4233

Signed-off-by: Michael Telatynski <[email protected]>

* Remove unused state field

Signed-off-by: Michael Telatynski <[email protected]>

* Discard changes to .prettierignore

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@florianduros florianduros florianduros approved these changes

@hughns hughns hughns approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t3chguy @andybalaam @florianduros @hughns