Lobster schema updates #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @utf , this PR is ready for review / merged |
|
@naik-aakash would this work on Windows? I guess not, right? |
Hi @JaGeo , I quickly ran the tests in atomate2 on a windows system, the schema test for LOBSTER works fine on windows as well, but the workflow ones fail during zipping output step for VASP runs. The change introduced here as no influence on this. But in general VASP core tests also fail on windows systems. |
JaGeo
approved these changes
Jul 30, 2024
|
@naik-aakash thanks! I have merged this as this is a small change ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #874
Changes
schematoatomate2_versionzpathobtained viamontyto work even with recent version of the monty package