Warn on non-default ATOMATE2_CONFIG_FILE that's not found
#794
+37
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in warn/err msg use monkeypatch.setenv to restore env var after test
janosh
commented
Mar 30, 2024
| @@ -10,6 +10,7 @@ | |||
| from pydantic_settings import BaseSettings, SettingsConfigDict | |||
|
|
|||
| _DEFAULT_CONFIG_FILE_PATH = "~/.atomate2.yaml" | |||
| _ENV_PREFIX = "atomate2_" | |||
There was a problem hiding this comment.
should this be upper-cased?
|
CI failure caused by |
hrushikesh-s
pushed a commit
to hrushikesh-s/atomate2
that referenced
this pull request
Jun 28, 2024
…sproject#794) * move _ENV_PREFIX = "atomate2_" into module scope * construct env var name ATOMATE2_CONFIG_FILE from _ENV_PREFIX and use in warn/err msg use monkeypatch.setenv to restore env var after test * Add warning for non-existent non-default config file * test no warning if config path is default and file does not exist * test warning if config path is non-default and file does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a small QoL improvement to warn users when they set a custom
ATOMATE2_CONFIG_FILEbut the file doesn't exist@utf i added tests to assert
also used
monkeypatch.setenv("ATOMATE2_CONFIG_FILE", ...)which is auto-reverted on test-exit to avoid polluting other tests