Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print invalid kpath_scheme, use_symmetrized_structure and list valid ones in PhononMaker error messages #728

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Feb 18, 2024

dbd7e99 PhononMaker print invalid values and list valid ones in for kpath_scheme, use_symmetrized_structure
3775076 fix cclib_calculate() wrong err msg claiming to return None when actually raising
f20c68e prefer tuple for static sequence literal
bd9b02a assert unused ret val distances in test_sort_pos_dist()
0f326f5 simplify dict construction in lobster read_saved_json(), LobsterTaskDocument.from_directory

@janosh janosh added fix Bug fix PR ux User experience qa labels Feb 18, 2024
@janosh janosh enabled auto-merge (squash) February 18, 2024 05:14
@janosh
Copy link
Member Author

janosh commented Feb 18, 2024

CI errors are unrelated caused by MP API. how about we skip those tests on GH or mock the API call @utf?

@janosh janosh disabled auto-merge February 18, 2024 05:45
@janosh janosh merged commit db340fe into main Feb 18, 2024
3 of 6 checks passed
@janosh janosh deleted the more-detailed-phonon-err-msg branch February 18, 2024 05:46
@janosh janosh changed the title Print invalid value and list valid ones in PhononMaker error messages Print invalid kpath_scheme, use_symmetrized_structure and list valid ones in PhononMaker error messages Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant