Skip to content

Commit

Permalink
build: use BUILDTYPE when building V8 in Makefile
Browse files Browse the repository at this point in the history
Without this it would always compile Release and Debug builds.

Ref: nodejs#7477
PR-URL: nodejs#7482
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
targos committed Jul 10, 2016
1 parent 69ef9b1 commit 22492db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ cctest: all

v8:
tools/make-v8.sh v8
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
$(MAKE) -C deps/v8 $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)

test: all
$(MAKE) build-addons
Expand Down

0 comments on commit 22492db

Please sign in to comment.