Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty admin image in doc #4239

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Update empty admin image in doc #4239

merged 1 commit into from
Jan 9, 2020

Conversation

zyhou
Copy link
Contributor

@zyhou zyhou commented Jan 3, 2020

Update empty admin image in doc

empty-admin

@zyhou zyhou added the RFR Ready For Review label Jan 3, 2020
@djhi djhi added this to the 3.1.2 milestone Jan 6, 2020
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with changing the screenshot of the welcome screen (displayed line 79, but outdated), but I don't see the interest of using a generator here - it doesn't save much typing, and it adds a level of indirection that hides the simplicity of the actual installation.

@zyhou zyhou changed the title Add cra-template-react-admin in doc Update empty admin image in doc Jan 7, 2020
@zyhou zyhou requested a review from fzaninotto January 7, 2020 13:11
@fzaninotto fzaninotto merged commit 6ec9474 into master Jan 9, 2020
@fzaninotto fzaninotto deleted the cra-template branch January 9, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants