chore: remove protractor from_src index (bazel-contrib#1862)

Use replacements during package publishing instead
marleypowell · May 4, 2020 · 2e9e61b · 2e9e61b
1 parent a85462d
commit 2e9e61b
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 36 deletions.
diff --git a/packages/protractor/BUILD.bazel b/packages/protractor/BUILD.bazel
@@ -42,6 +42,9 @@ pkg_npm(
         "@npm_bazel_protractor//:package_contents",
     ],
     build_file_content = """exports_files(["protractor.conf.js"])""",
+    substitutions = {
+        "@npm_bazel_protractor//:utils_lib": "@npm//@bazel/protractor",
+    },
     vendor_external = [
         "npm_bazel_protractor",
     ],

diff --git a/packages/protractor/src/index.from_src.bzl b/packages/protractor/src/index.from_src.bzl
diff --git a/packages/protractor/src/protractor_web_test.bzl b/packages/protractor/src/protractor_web_test.bzl
@@ -20,7 +20,8 @@ load("@io_bazel_rules_webtesting//web:web.bzl", "web_test_suite")
 load("@io_bazel_rules_webtesting//web/internal:constants.bzl", "DEFAULT_WRAPPED_TEST_TAGS")
 
 _PROTRACTOR_PEER_DEPS = [
-    "@npm//@bazel/protractor",
+    # NB: replaced during pkg_npm with "@npm//@bazel/protractor",
+    "@npm_bazel_protractor//:utils_lib",
     "@npm//protractor",
 ]
 _PROTRACTOR_ENTRY_POINT = "@npm//:node_modules/protractor/bin/protractor"

diff --git a/packages/protractor/test/protractor-2/BUILD.bazel b/packages/protractor/test/protractor-2/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("@npm_bazel_protractor//:index.from_src.bzl", "protractor_web_test_suite")
+load("@npm_bazel_protractor//:index.bzl", "protractor_web_test_suite")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 load("@npm_bazel_typescript//:index.bzl", "ts_config", "ts_devserver", "ts_library")

diff --git a/packages/protractor/test/protractor/BUILD.bazel b/packages/protractor/test/protractor/BUILD.bazel
@@ -1,4 +1,4 @@
-load("@npm_bazel_protractor//:index.from_src.bzl", "protractor_web_test_suite")
+load("@npm_bazel_protractor//:index.bzl", "protractor_web_test_suite")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 
 ts_library(