Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging views #308

Closed
maniserowicz opened this issue Sep 24, 2013 · 1 comment
Closed

Paging views #308

maniserowicz opened this issue Sep 24, 2013 · 1 comment

Comments

@maniserowicz
Copy link
Contributor

Currently views cannot be paged using Simple.Data because they do not have primary keys.
The problem is that keys are really necessary in the SqlQueryPager. Even SqlCe40QueryPager that comes with Simple.Data does not require them. MySql pager would ignore the keys too. And our PostgreSQL pager (found here, forked from the "official" one that seems to be abandoned: https://github.com/ultrico/Simple.Data.PostgreSql ) does not need them either.
Wouldn't it be a good idea to allow paging on tables/views without primary key and move this exception from AdoAdapterQueryRunner to SqlQueryPager ?

https://github.com/markrendle/Simple.Data/blob/master/Simple.Data.Ado/AdoAdapterQueryRunner.cs#L188

@MattBecker
Copy link

If I understand the pull request properly, this was only applied to the v2.0.0-alpha1 branch, and not Simple.Data.Core 1.0.0-rc3. Is that correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants