Fix collectionView reset buffer itemView show condition #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cobbweb for a review |
| }); | ||
|
|
||
| it("collectionView should not be buffering on itemView show", function() { | ||
| cvInstance = new cv({collection: collection}); |
There was a problem hiding this comment.
I think the norm with the tests is that any instances you create should be initialized in beforeEach.
beforeEach(function() {
isBuffering = null;
cvInstance = new cv({collection: collection});
cvInstance.render().trigger('show');
});
|
updated @cobbweb ! |
| describe("when a collection is reset itemViews should not be shown until the buffering is over", function() { | ||
| var isBuffering, iv, cv, collection, cvInstance; | ||
|
|
||
| collection = new Backbone.Collection([{}]); |
There was a problem hiding this comment.
Oh sorry, this guy should probably be moved into the beforeEach too. After that looks goods :)
There was a problem hiding this comment.
good catch 👍 all resolved
When a collectionView was rendered and then reset, the itemView had show called while it was still in the dom fragment. Thus invalidating show and onDomRefresh fixes #843
cobbweb
added a commit
that referenced
this pull request
Jan 13, 2014
Fix collectionView reset buffer itemView show condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a collectionView was rendered and then reset, the itemView had
show called while it was still in the dom fragment.
Thus invalidating show and onDomRefresh
fixes #843