Trigger Region close event with view that's being closed #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cobbweb just wondering the value of this, since you have to bind to the close event on the view instance what value do you see passing it also? Maybe a use case would convince me :) |
|
This is the |
|
:p , yeah sorry I read the code incorrectly |
|
Yea I read the initial issue the same way hehe... the docs I'm talking about are here BTW |
samccone
added a commit
that referenced
this pull request
Jan 8, 2014
…view Trigger Region close event with view that's being closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what devs might want with a closed view, but at least this is consistent and does what the docs say. Fixes #821.