This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Omit empty resources #318
Merged
Omit empty resources #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before
After
|
| for path in resources: | ||
| apis.append({'path': '/%s' % path, }) | ||
|
|
||
| apis = [{'path': '/' + path} for path in self.get_resources()] |
There was a problem hiding this comment.
Because David Beazley told me it's ok.
But in any event, the string formatting in this file is pretty schizophrenic and '%s' % value is less favourable to '{}'.format(value) or '{0}'.format(value) says python docs.
|
rebase, perhaps? |
By filtering before trying to determine the top-level resources, empty top-level resources will be correctly ignored.
mverteuil
force-pushed
the
omit_empty_resources
branch
from
8437bc4
to
f9675ee
Compare
|
Rebased 💇 |
|
Investigating the test failures now. |
|
|
|
I wasn't aware that It was a good thing your test exercised this, or it would have probably caused some curious issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've amended the code for handling resource access because I've found a bug that is exercised by one of my use cases. If all of the APIs provided by a Resource are excluded by
handle_resource_access, and that resource is actually just a label to collect a bunch of similar APIs together, then that Resource will show up. This is problematic because:The problem is solved simply by doing the check at an earlier stage of processing.