Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mongodb:// URL scheme #51

Closed
wants to merge 1 commit into from

Conversation

mschuetz
Copy link

Hi Marcello,

I noticed that the connection URL one gets from mongohq/heroku use the URL scheme mongodb:// instead of mongo:// and hence added support for that.

Cheers

Matthias

@marcello3d
Copy link
Owner

If you use (?:db)? it will be a non-matching group (and you won't have to change all the match numbers). We should update the documentation as well.

I'm also fine with only supporting "mongodb://" if that's the emerging standard, it'd be nice to keep things simple.

(On an unrelated note, it looks like there's a typo in the existing new Error bit... should be + url instead of + arg. I'll fix that.)

@mschuetz mschuetz closed this Sep 4, 2011
@mschuetz mschuetz reopened this Sep 4, 2011
@mschuetz
Copy link
Author

mschuetz commented Sep 4, 2011

I reimplemented the whole thing using the builtin URL parser. What do you think about that? 27da610

@marcello3d
Copy link
Owner

It's clever, but too complicated. Unfortunately it also loses some of functionality of the original, e.g. being able to use just the string "127.0.0.1:27000". It's also not clear how it will handle usernames or passwords with ':' in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants