Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in wasm worker [#21] #22

Merged
merged 3 commits into from
Feb 24, 2023
Merged

fix memory leak in wasm worker [#21] #22

merged 3 commits into from
Feb 24, 2023

Conversation

bdon
Copy link
Collaborator

@bdon bdon commented Feb 21, 2023

Fixes #21 .

Changes proposed in this pull request: balance malloc with free call

@ChrisLoer

ChrisLoer
ChrisLoer approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to move the font_data free to after free_fontstack, but this should already be good enough to prevent the leak.

app/public/worker.js Show resolved Hide resolved
@bdon bdon merged commit 468d9ea into maplibre:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM Memory leak
2 participants
@bdon @ChrisLoer