Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show selected area in filter mode #577

Closed
sonicnkt opened this issue Jan 14, 2023 · 2 comments
Closed

Show selected area in filter mode #577

sonicnkt opened this issue Jan 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working selection Everything related to the selection management tools bugs or suggestions related to tools
Milestone

Comments

@sonicnkt
Copy link

sonicnkt commented Jan 14, 2023

Description

So i was looking for a simple image annotation tool for screenshots annotations.
A typical task for me is to select an area and make it non legible.
Here i am encountering the following odd behaviour:
Either the selected area is not shown at all when switching to the Filter mode or the selected area is black.
Applying the filter by clicking on the area works fine tho.

Since i have never used the app before i am not sure what is supposed to be the default behaviour but since it changes on its own there seems to be some bug going on.

Here are some screenshots:
grafik
grafik
grafik

Steps to reproduce the bug

  1. Open Image
  2. Select Area (rectangle or free)
  3. Switch to Filter mode
  4. The selected area is not displayed (highlighted?)
  5. Return to Select Area mode (RED back button)
  6. Click on Filters again
  7. Now the selected area is displayed black.

System

  • Device: Desktop PC, X86_64, AMD GPU with Mesa drivers
  • OS: Fedora 37
  • Desktop environment: Gnome 43, Wayland Session
  • Package format: native
  • App version: 1.0.1
@sonicnkt sonicnkt added the bug Something isn't working label Jan 14, 2023
@maoschanz
Copy link
Owner

yes it's a bug, it happens only with the blurring filters tho

the normal behavior is to immediately preview the selected filter with the selected options (by default: saturation at 100%, aka no changes at all), but computing blur in python is painfully slow so when the filter is this one, the app doesn't try anything unless you click

for the next version i'll show the unblurred image by default i think, but eventually i should look for a less naive way to apply convolutions to an image lol

@maoschanz maoschanz added tools bugs or suggestions related to tools selection Everything related to the selection management labels Jan 20, 2023
@maoschanz maoschanz added this to the 1.2.0 milestone Jan 20, 2023
@maoschanz maoschanz self-assigned this Jan 20, 2023
@sonicnkt
Copy link
Author

sonicnkt commented Jan 21, 2023

Ah in understand :) i must have missed the default behaviour since i immediately set it to blur/mosaic for my common workflow. Thanks for looking into this!

I don't mind it being a bit slow since for quick annotations/blur/etc its still a lot quicker than open gimp and doing it more "manually". Have been using ksnip in the past as an all in one solution but on gnome 43 with wayland it isn't working that great any more so i just use the nativ screenshot, combined with drawing it is a nice solution.

maoschanz added a commit that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working selection Everything related to the selection management tools bugs or suggestions related to tools
Projects
None yet
Development

No branches or pull requests

2 participants