Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assign_or in favor of json::value #2487

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove assign_or in favor of json::value #2487

merged 1 commit into from
Apr 24, 2023

Conversation

AntoinePrv
Copy link
Member

There is a function for that (nlohmann::json::value).

@AntoinePrv AntoinePrv added the type::cleanup Internal code quality improvement label Apr 24, 2023
@AntoinePrv AntoinePrv changed the title Remove in favor of json::value Remove assign_or in favor of json::value Apr 24, 2023
@AntoinePrv AntoinePrv changed the title Remove assign_or in favor of json::value Remove assign_or in favor of json::value Apr 24, 2023
@AntoinePrv AntoinePrv merged commit c0b57d1 into mamba-org:main Apr 24, 2023
@AntoinePrv AntoinePrv deleted the remove-assign-or branch April 24, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@Hind-M Hind-M Hind-M approved these changes

@jonashaag jonashaag Awaiting requested review from jonashaag

Assignees
No one assigned
Labels
type::cleanup Internal code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoinePrv @JohanMabille @Hind-M