Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit tests for createAccountPage asyncActions #887

Merged
merged 5 commits into from
Feb 13, 2019
Merged

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Feb 11, 2019

Description

Adds unit tests for createAccountPage/asyncActions.js.

Related Issue

Closes #886 .

Motivation and Context

Part of the ongoing effort to shore up unit test coverage in Venia.

How Has This Been Tested?

yarn test.

Screenshots (if appropriate):

Proposed Labels for Change Type/Package

TEST

venia-concept

Checklist:

  • I have read the CONTRIBUTING document.
  • I have linked an issue to this PR.
  • I have indicated the change type and relevant package(s).
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All CI checks are green (linting, build/deploy, etc).
  • At least one core contributor has approved this PR.

@vercel
Copy link

vercel bot commented Feb 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@supernova-at supernova-at added the test This pertains to testing (unit/functional/etc). label Feb 11, 2019
@vercel vercel bot temporarily deployed to staging February 11, 2019 21:00 Inactive
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 61.977% when pulling 6f3d795 on supernova/886 into e4568a8 on release/2.0.

@coveralls
Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage increased (+0.09%) to 68.551% when pulling 42419de on supernova/886 into 548412e on release/2.0.

@vercel vercel bot temporarily deployed to staging February 13, 2019 20:31 Inactive
@sirugh sirugh merged commit 7e7a9b1 into release/2.0 Feb 13, 2019
@supernova-at supernova-at deleted the supernova/886 branch May 2, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This pertains to testing (unit/functional/etc).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants