Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3112::The link seems to not be working with the keyboard. When th… #4094

Merged
merged 5 commits into from
May 16, 2023

Conversation

glo80771
Copy link
Contributor

…e ENTER key is pressed, nothing is happening

Description

The link seems to not be working with the keyboard. When the ENTER key is pressed, nothing is happening

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3112.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…e ENTER key is pressed, nothing is happening
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 19, 2023

Messages
📖

Associated JIRA tickets: PWA-3112.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ab147a2

@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 19, 2023
@glo42707
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Apr 20, 2023

Successfully started codebuild job for lighthouse-desktop

@glo42707
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Apr 20, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

glo82145 commented May 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

glo82145 commented May 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 7b8c4f1 into develop May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants