Fix iOS Safari by patching Intl.NumberFormat #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetlen
requested review from
antonkril,
mhhansen,
jimbo,
pcvonz,
Crifen,
Starotitorov,
Serunde,
artKozinets and
JStein92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
Safari doesn't have the Intl.NumberFormat.prototype.formatToParts method, which
Price.jsexpects. The resulting error causes the whole application to crash and the screen goes blank.Rather than including the 150kb IntlPolyfill core, this PR includes a small and well-tested implementation of
.formatToPartsextracted from that library.iOS Safari before:
iOS Safari after: