Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #3878

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix flaky test #3878

merged 3 commits into from
Jun 16, 2022

Conversation

dpatil-magento
Copy link
Contributor

Description

Test has hard asserts but they are failing randomly. Given data correctness is being checked part of graphql/unit tests and we dont want these assertion in UI cases, updated assertions.

Related Issue

Closes PWA-2882

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. This Un-skipped test should pass in cypress build

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 14, 2022

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-2882.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 617233b

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 14, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 16, 2022

Successfully started codebuild job for cypress

@dpatil-magento dpatil-magento merged commit a9f0639 into develop Jun 16, 2022
@dpatil-magento dpatil-magento deleted the dev/fix-flky branch June 16, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants