Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise docs and add to side nav #302

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Revise docs and add to side nav #302

merged 2 commits into from
Oct 16, 2018

Conversation

jcalcaben
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[X] Documentation

Summary

When this pull request is merged, it will revise the CSS module topic content from #296

Additional information

This PR closes #48

@jcalcaben jcalcaben added this to the Sprint 26 milestone Sep 26, 2018
@jcalcaben jcalcaben self-assigned this Sep 26, 2018
@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 15.944% when pulling 06df50e on jimothy/GH-48_revise-css-modules-docs into 0f8447c on release/2.0.

@zetlen zetlen changed the base branch from master to release/2.0 September 27, 2018 18:01
mhhansen
mhhansen approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@mhhansen mhhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better the revised version james, great improve 👍

@ericerway ericerway modified the milestones: Sprint 26, Sprint 27 Oct 10, 2018
zetlen
zetlen approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding. Very well explained.

We should at some point add an explanation of CSS Variables and how they help us centralize common settings, but that can come later.

@zetlen zetlen merged commit ce90f0f into release/2.0 Oct 16, 2018
@jcalcaben jcalcaben deleted the jimothy/GH-48_revise-css-modules-docs branch July 25, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhhansen mhhansen mhhansen approved these changes

@zetlen zetlen zetlen approved these changes

@jimbo jimbo Awaiting requested review from jimbo

Assignees

@jcalcaben jcalcaben

Labels
pkg:pwa-devdocs
Projects
None yet
Milestone
Sprint 27
Development

Successfully merging this pull request may close these issues.
5 participants
@jcalcaben @coveralls @mhhansen @zetlen @ericerway