Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-Videos: Added Page Builder integration videos #2632

Merged
merged 4 commits into from
Aug 27, 2020
Merged

PB-Videos: Added Page Builder integration videos #2632

merged 4 commits into from
Aug 27, 2020

Conversation

bdenham
Copy link
Contributor

@bdenham bdenham commented Aug 16, 2020 •
edited
Loading

Description

Added long lost Page Builder integration videos to their proper place in the overview page of the PWA Page Builder integration docs.

Related Issue

Closes #2631

Acceptance

Verification Stakeholders

Verification Steps

  1. Build the docs site locally.
  2. Verify that the videos load and run.

Screenshots / Screen Captures (if appropriate)

image

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@bdenham bdenham mentioned this pull request Aug 16, 2020
Closed
2 tasks
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 16, 2020 •
edited
Loading

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 21945b6

jcalcaben
jcalcaben previously approved these changes Aug 17, 2020
View reviewed changes
omiroshnichenko
omiroshnichenko reviewed Aug 17, 2020
View reviewed changes
pwa-devdocs/src/pagebuilder/index.md Outdated

* Populates those React components with the content and style properties from the original content types (**ContentTypeFactory and content type components**)
1. And finally, it returns those components for for display in a PWA Studio app (**PageBuilder** and **RichContent** components)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed

@bdenham bdenham dismissed stale reviews from omiroshnichenko and jcalcaben via 720babc August 17, 2020 20:25
@bdenham bdenham requested a review from jcalcaben August 19, 2020 13:19
@dpatil-magento dpatil-magento merged commit 880c1a1 into magento:develop Aug 27, 2020
@bdenham bdenham deleted the PB-Videos branch August 28, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcalcaben jcalcaben jcalcaben approved these changes

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

Assignees

@bdenham bdenham

@jcalcaben jcalcaben

@omiroshnichenko omiroshnichenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc]: Add Page Builder integration videos
5 participants
@bdenham @PWAStudioBot @jcalcaben @omiroshnichenko @dpatil-magento